Issue 10003: signal.SIGBREAK regression on windows (original) (raw)

Created on 2010-10-01 01:07 by gz, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
sigbreak_windows_10003.patch gz,2010-10-01 01:11 Patch to permit SIGBREAK on windows again
Messages (4)
msg117769 - (view) Author: Martin (gz) * Date: 2010-10-01 01:07
The change in response to bug 9324 breaks bzr on windows as we use signal.SIGBREAK to listen for a ctrl+break keyboard press. Although SIGBREAK is not documented as valid on: <http://msdn.microsoft.com/library/xdkz3x12> It does in fact work and corresponds to CTRL_BREAK_EVENT in native windows terms.
msg117771 - (view) Author: Martin (gz) * Date: 2010-10-01 01:11
Also, the test seems to set signal handlers and never unset them, which I've also corrected.
msg117816 - (view) Author: Brian Curtin (brian.curtin) * (Python committer) Date: 2010-10-01 16:45
Fixed in r85140 (py3k), r85141 (release31-maint), and r85145 (release27-maint). Thanks for the report!
msg117817 - (view) Author: Martin (gz) * Date: 2010-10-01 17:17
Thanks for the quick resolution Brian, head now works as expected.
History
Date User Action Args
2022-04-11 14:57:07 admin set github: 54212
2010-10-01 17:17:11 gz set messages: +
2010-10-01 16:45:07 brian.curtin set status: open -> closedresolution: accepted -> fixedmessages: + stage: patch review -> resolved
2010-10-01 01:36:25 brian.curtin set type: behaviorstage: patch reviewresolution: acceptedassignee: brian.curtinversions: - Python 3.3
2010-10-01 01:11:04 gz set files: + sigbreak_windows_10003.patchkeywords: + patchmessages: +
2010-10-01 01:07:57 gz create