Issue 10191: scripts files are not RECORDed. (original) (raw)

Created on 2010-10-25 13:55 by Atsushi.Odagiri, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
hello.zip Atsushi.Odagiri,2010-10-25 13:55 package including scripts file.
test-record-scripts-10191.diff eric.araujo,2011-06-09 14:42 review
Messages (7)
msg119550 - (view) Author: Atsushi Odagiri (Atsushi.Odagiri) Date: 2010-10-25 13:55
I wrote setup.py includes scripts with distutils2, and ran `setup.py install`. scripts were installed in scripts directory, but not recorded in .dist-info/RECORD. I think that `distutils2._backport.shutil:copytree` should return copied filenames.
msg119845 - (view) Author: Éric Araujo (eric.araujo) * (Python committer) Date: 2010-10-29 02:53
Thanks for the report. This is indeed a bug with respect to PEP 376. It would be too difficult to modify shutil (and copy2) to make it return filenames, but thanks to the new copy_function hook it will be easy to store filenames in a list and use that. I’ll have to synchronize _backport.shutil with the 3.2 version first.
msg124092 - (view) Author: Éric Araujo (eric.araujo) * (Python committer) Date: 2010-12-15 23:09
For the record, I have started work on this, then stopped due to lack of time. I’ll get back to it.
msg137975 - (view) Author: Éric Araujo (eric.araujo) * (Python committer) Date: 2011-06-09 14:42
I wrote a test but it did not fail. Can you test it too?
msg138047 - (view) Author: Atsushi Odagiri (Atsushi.Odagiri) Date: 2011-06-10 04:44
OK, I'll test it too. I looked sources of packaging. That use packaging.utils.copy_tree. When I reported that problem, install_scripts used _backport.shutil.copytree. Maybe problem is fixed, because it reterned copied file lists. Is that fixies applied to distutils2?
msg138085 - (view) Author: Éric Araujo (eric.araujo) * (Python committer) Date: 2011-06-10 15:43
> OK, I'll test it too. Thanks. In case you’re not sure how to test my patch, see http://docs.python.org/devguide/faq#how-do-i-apply-a-patch and http://docs.python.org/devguide/runtests > I looked sources of packaging. That use packaging.utils.copy_tree. > When I reported that problem, install_scripts used backport.shutil.copytree. Ah, I see a comment in the code that copy_tree should be replaced by shutil.copytree, so we need to get the test anyway to make sure changing the code later will not cause a regression. > Maybe problem is fixed, because it reterned copied file lists. Indeed. > Is that fixies applied to distutils2? distutils2 will be recreated as a backport of packaging. IOW, the packaging module in the 3.3 stdlib is the distutils2 project.
msg143407 - (view) Author: Éric Araujo (eric.araujo) * (Python committer) Date: 2011-09-02 16:05
I have added tests for scripts in RECORD and they pass. Closing, please reopen if you can reproduce the bug.
History
Date User Action Args
2022-04-11 14:57:07 admin set github: 54400
2011-09-02 16:05:22 eric.araujo set status: open -> closedresolution: not a bugmessages: + stage: resolved
2011-06-10 15:43:45 eric.araujo set messages: +
2011-06-10 04:44:58 Atsushi.Odagiri set messages: +
2011-06-09 14:42:16 eric.araujo set files: + test-record-scripts-10191.diffkeywords: + patchmessages: + versions: + Python 3.3, - 3rd party
2010-12-15 23:09:04 eric.araujo set nosy:tarek, eric.araujo, Atsushi.Odagirimessages: +
2010-10-29 02:53:12 eric.araujo set assignee: tarek -> eric.araujomessages: + versions: + 3rd party, - Python 2.6
2010-10-25 13:55:46 Atsushi.Odagiri create