Issue 1034: [patch] Add 2to3 support for displaying warnings as Python comments (original) (raw)

Issue1034

Created on 2007-08-27 02:20 by adrianholovaty, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (6)
msg55331 - (view)	Author: Adrian Holovaty (adrianholovaty)	Date: 2007-08-27 02:20
Per a Python-3000 mailing list discussion here -- http://mail.python.org/pipermail/python-3000/2007-August/009835.html -- I have implemented an addition to the 2to3 utility that enables warnings to be output as comments in Python source code instead of being logged to stdout. See the attached patch and a description of the changes here: http://mail.python.org/pipermail/python-3000/2007-August/009881.html
msg55332 - (view)	Author: Adrian Holovaty (adrianholovaty)	Date: 2007-08-27 02:21
I'm also attaching 2to3_comment_warnings.diff, which is an example of how we could integrate the insert_comment() method from the first patch to replace the current functionality of fixes.basefix.BaseFix.warning().
msg73152 - (view)	Author: Benjamin Peterson (benjamin.peterson) *	Date: 2008-09-12 23:11
On the patch: 1. I think both a log message and the comment should be written. The point needs to be reinforced to users. 2. I'd like to see some tests. 3. Maybe an option to turn the auto comments off? This is interesting. I'd like to have someone else weigh in before it is applied though.
msg97342 - (view)	Author: Brian Curtin (brian.curtin) *	Date: 2010-01-07 04:29
I think this would be a good addition so I took Adrian's patch and brought it up to date. I'll need to expand the testing, but I think Benjamin's 1 and 3 are covered.
msg116774 - (view)	Author: Mark Lawrence (BreamoreBoy) *	Date: 2010-09-18 13:13
Removed 2.7 as too late, can we get this into 3.2?
msg213599 - (view)	Author: Éric Araujo (eric.araujo) *	Date: 2014-03-14 22:44
(2to3 is an exception and can get improvements in stable versions.)