My build slave shows a test failure at test_dont_copy_file_onto_link_to_itself. This happens because the implementation of _samefile in Lib/shutil.py (line 70) doesn't work for Windows hard links. Patch on the way.
Here is a patch. os.path.samefile and hard links don't work for Windows the same way they do for Mac/Linux. In the case where we are on Windows and a link comes into the _samefile function, check that it's a link and then use os.path.sameopenfile. If it's not a link but a regular file, or it's some other OS, do the os.path.samefile check.
This hasn't been an issue for quite some time, and I suspect the follow-up work on symbolic and hard links and their supporting functions corrected any problems in this area.
History
Date
User
Action
Args
2022-04-11 14:57:09
admin
set
github: 54749
2011-04-20 00:55:10
brian.curtin
set
status: open -> closedresolution: works for memessages: + stage: needs patch -> resolved
