| msg122747 - (view) |
Author: Jakub Wilk (jwilk) |
Date: 2010-11-28 23:38 |
| $ python3 --version Python 3.1.3 $ python3 setup.py bdist upload --sign [snip] Traceback (most recent call last): File "setup.py", line 71, in cmdclass = dict(build_py=build_py) File "/usr/local/lib/python3.1/distutils/core.py", line 149, in setup dist.run_commands() File "/usr/local/lib/python3.1/distutils/dist.py", line 919, in run_commands self.run_command(cmd) File "/usr/local/lib/python3.1/distutils/dist.py", line 938, in run_command cmd_obj.run() File "/usr/local/lib/python3.1/distutils/command/upload.py", line 66, in run self.upload_file(command, pyversion, filename) File "/usr/local/lib/python3.1/distutils/command/upload.py", line 155, in upload_file body.write(value) TypeError: 'str' does not support the buffer interface Without --sign it works just fine. |
|
|
| msg122802 - (view) |
Author: Éric Araujo (eric.araujo) *  |
Date: 2010-11-29 14:10 |
| Thank you for the report. Do you want to propose a patch? |
|
|
| msg122807 - (view) |
Author: Jakub Wilk (jwilk) |
Date: 2010-11-29 15:05 |
| Patch attached. |
|
|
| msg122813 - (view) |
Author: Éric Araujo (eric.araujo) * |
Date: 2010-11-29 15:29 |
| Thank you. I’ll apply after #10578 is solved. |
|
|
| msg122814 - (view) |
Author: Tarek Ziadé (tarek) * |
Date: 2010-11-29 15:34 |
| Eric: #10578 will not happen in Distutils1. You need to add a test in distutils2, apply the bugfix there, then apply Jakub's patch in distutils1 |
|
|
| msg164297 - (view) |
Author: Roundup Robot (python-dev)  |
Date: 2012-06-28 23:07 |
| New changeset ef16a3db4628 by Antoine Pitrou in branch '3.2': Issue #10571: Fix the "--sign" option of distutils' upload command. http://hg.python.org/cpython/rev/ef16a3db4628 New changeset b45f105dbdfb by Antoine Pitrou in branch 'default': Issue #10571: Fix the "--sign" option of distutils' upload command. http://hg.python.org/cpython/rev/b45f105dbdfb |
|
|
| msg164298 - (view) |
Author: Antoine Pitrou (pitrou) * |
Date: 2012-06-28 23:08 |
| Committed. Thank you Jakub! |
|
|
| msg164574 - (view) |
Author: Éric Araujo (eric.araujo) * |
Date: 2012-07-03 05:26 |
| Reopening for d2. According to our rules a unit test would be required, but if we don’t have machinery to test upload already in place then I would just commit it; we definitely want to have automated tests for all commands, but it needn’t hold up this fix. |
|
|
| msg214798 - (view) |
Author: Éric Araujo (eric.araujo) * |
Date: 2014-03-25 09:24 |
| distutils2 development has ceased. |
|
|