Issue 10765: Build regression from automation changes on windows (original) (raw)

Created on 2010-12-23 23:19 by gz, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
py3k_build.patch gz,2010-12-23 23:19 Throw quotes around till it works review
Messages (9)
msg124575 - (view) Author: Martin (gz) * Date: 2010-12-23 23:19
The build changes in r87093 broke me, as my py3k branch is under a dir with a space in the name, and the OutDir path needs escaping in the makefiles. Various extra quoting seems to be sufficient, though inelegant.
msg124577 - (view) Author: Martin (gz) * Date: 2010-12-23 23:38
Oh, and after building with this, I get: $ svn st ? PC/python3dll.obj So either that wants moving or svn:ignore needs updating.
msg127261 - (view) Author: Martin (gz) * Date: 2011-01-28 09:25
My build is still affected by this, can you find some time to look at the attached patch please? Relevant bit of log is: Performing Makefile project actions Microsoft (R) Program Maintenance Utility Version 9.00.21022.08 Copyright (C) Microsoft Corporation. All rights reserved. NMAKE : fatal error U1073: don't know how to make 'User\py3k\PCbuild\' Stop. Project : error PRJ0019: A tool returned an error code from "Performing Makefile project actions"
msg160161 - (view) Author: Ezio Melotti (ezio.melotti) * (Python committer) Date: 2012-05-07 17:02
Can you still reproduce this?
msg160215 - (view) Author: Martin (gz) * Date: 2012-05-08 17:26
Yes, this is still reproducible. For instance, by: > hg clone -b default 3.3 "feature branch" > cd "feature branch/PCbuild" > call build_env.bat > call build.bat It seems python33.dll now does get created so it's less severe, but the python3dll still fails due to the makefile OutDir not being quoted: NMAKE : fatal error U1073: don't know how to make 'branch\PCbuild\'
msg160237 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2012-05-09 00:33
As there is an easy work-around (just don't use spaces in directory names), I still consider this issue as irrelevant as two years ago.
msg160344 - (view) Author: Ezio Melotti (ezio.melotti) * (Python committer) Date: 2012-05-10 13:23
Avoiding spaces in the dir names might not be so easy, if e.g. you are trying to install it in "Program Files", "Users/Name Surname", or some other system directory that has spaces in there (sure, you could install it elsewhere, but in 2012 this shouldn't be an issue anymore).
msg220001 - (view) Author: Mark Lawrence (BreamoreBoy) * Date: 2014-06-07 23:44
I agree with the sentiment expressed in . Having said that I believe that a lot of work has been put into the build system recently that might have covered this.
msg276671 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2016-09-16 03:25
The build system has been completely rewritten at least once since this was opened; this should no longer be a problem.
History
Date User Action Args
2022-04-11 14:57:10 admin set github: 54974
2016-09-16 03:25:28 zach.ware set status: open -> closedresolution: out of datemessages: + stage: patch review -> resolved
2014-06-29 09:46:01 ezio.melotti set nosy: + vstinner, zach.ware, steve.dower
2014-06-08 00:17:52 brian.curtin set nosy: - brian.curtin
2014-06-07 23:44:20 BreamoreBoy set nosy: + BreamoreBoymessages: +
2012-05-10 13:23:01 ezio.melotti set messages: + stage: patch review
2012-05-09 00:33:12 loewis set messages: +
2012-05-08 17:26:50 gz set messages: + versions: + Python 3.3
2012-05-07 21:09:22 pitrou set nosy: + brian.curtin
2012-05-07 17:02:31 ezio.melotti set nosy: + ezio.melottimessages: +
2011-01-28 09:25:36 gz set messages: +
2010-12-23 23:38:51 gz set messages: +
2010-12-23 23:19:03 gz create