Seems like doctest won't recognize functions inside the module under test are actually in that module, if the function is decorated by a decorator that wraps the function in an externally defined function, such as in this silly example: # decorator.py import functools def simplelog(f): @functools.wraps(f) def new_f(*args, **kwds): print "Wrapper calling func" return f(*args, **kwds) return new_f # test.py from decorator import simplelog @simplelog def test(): """ This test should fail, since the decorator prints output. Seems I don't get called though >>> test() 'works!' """ return "works!" if __name__ == '__main__': import doctest doctest.testmod() -- The problem lies in DocTestFinder._from_module, which checks if the function's func_globals attribute is the same as the module's __dict__ attribute. I'd propose to do the __module__/inspect.getmodule() checks (aren't they both checking the same thing btw?) before the inspect.isfunction check.
I applied this patch to my trunk sandbox. It seems to solve the problem I just encountered where doctests are hidden in decorated functions & tests pass. Checked in as r67277. Should be backported to 2.6 and forward ported to 3.0.
For what it's worth, this bug appears to go back to at least Python 2.4, and it affects functions using decorators even if they are defined in the same module as the decorated function. I've applied the patch to my 2.4 installation, and it doesn't fix the issue. I'd like to request this be reopened, because I don't believe the patch works as advertised. I've attached a simple script which should demonstrate the issue. Run it with "python doctestfail.py [-v]", and if it passes with no failures, the bug still exists. I've tested it on 2.4 before and after the patch. (Apologies for not having anything more recent at the moment.)
Earlier I wrote: "I've applied the patch to my 2.4 installation, and it doesn't fix the issue. I'd like to request this be reopened, because I don't believe the patch works as advertised." Nevermind, I withdraw the request. I believe I was mislead due to the decorated function not having it's docstring automatically copied from the original without the use of functools.wraps().
