Issue 1150: Rename PyBUF_WRITEABLE to PyBUF_WRITABLE (original) (raw)

Issue1150

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

This issue has been migrated to GitHub: https://github.com/python/cpython/issues/45491

classification

Title: Rename PyBUF_WRITEABLE to PyBUF_WRITABLE
Type: Stage:
Components: Versions: Python 3.0

process

Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: jafo Nosy List: gvanrossum, jafo
Priority: low Keywords: patch

Created on 2007-09-11 18:23 by gvanrossum, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
py3k-trunk-writeable.patch jafo,2007-09-17 10:48
Messages (4)
msg55830 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2007-09-11 18:23
Because writeable is not an English word; writable is. Other names should be fixed as well.
msg55961 - (view) Author: Sean Reifschneider (jafo) * (Python committer) Date: 2007-09-17 10:48
Attached is a patch that fixes "writeable". I'm thinking, close this if the patch looks ok, and open another for a general "identify non-englishisms" ticket, once they're identified a ticket could be opened to fix them. I fixed only the PyBUF instances but also documents and comments and doc strings and printfs where it occurred. Yes? Let me know if it looks good to commit. Does this need a fix in 2to3?
msg55965 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2007-09-17 15:05
Looks good. Check it in, with one small addition: add #define PyBUF_WRITEABLE PyBUF_WRITABLE for those NumPy folks who can't help writing the alternate spelling ('writeable' *is* in some dictionaries, though it is consistently flagged as invalid by spell checkers).
msg55971 - (view) Author: Sean Reifschneider (jafo) * (Python committer) Date: 2007-09-17 17:57
Comitted as revision 58182, with additional change mentioned by Guido.
History
Date User Action Args
2022-04-11 14:56:26 admin set github: 45491
2007-09-17 17:57:18 jafo set messages: +
2007-09-17 17:56:12 jafo set status: open -> closed
2007-09-17 15:05:39 gvanrossum set assignee: gvanrossum -> jaforesolution: acceptedmessages: +
2007-09-17 10:48:15 jafo set files: + py3k-trunk-writeable.patchnosy: + jafomessages: + priority: lowassignee: gvanrossumkeywords: + patch
2007-09-11 18:23:03 gvanrossum create