| msg130957 - (view) |
Author: Denver Coneybeare (denversc) * |
Date: 2011-03-15 05:31 |
| The attached patch increases the test coverage of the module _dummy_thread from 78% to 100%. |
|
|
| msg139070 - (view) |
Author: Sandro Tosi (sandro.tosi) *  |
Date: 2011-06-25 14:24 |
| I run a review on rietveld, just minor stuff (even though I don't see the 100% coverage). |
|
|
| msg151641 - (view) |
Author: Sandro Tosi (sandro.tosi) * |
Date: 2012-01-19 16:18 |
| Hi Denver, do you have the time to address the review on rietveld and propose a new patch? |
|
|
| msg151760 - (view) |
Author: Denver Coneybeare (denversc) * |
Date: 2012-01-22 04:29 |
| I've looked at the review (thanks for the review) and can submit an updated patch. I don't have the Python source code pulled down to my PC anymore so it might take a week or two before I'm able to update the patch and test it out. I imagine that's not too much of a problem though :) |
|
|
| msg223332 - (view) |
Author: Mark Lawrence (BreamoreBoy) * |
Date: 2014-07-17 13:06 |
| @Denver are you still interested in working on this as a week or two has passed? :) |
|
|
| msg258751 - (view) |
Author: Berker Peksag (berker.peksag) * |
Date: 2016-01-21 10:07 |
| Thanks for the patch, Denver. Two things: 1. MockFunction needs to be replaced with unittest.mock.Mock. 2. Comments from Sandro and Ezio needs to be addressed. |
|
|
| msg274785 - (view) |
Author: Senthil Kumaran (orsenthil) * |
Date: 2016-09-07 09:43 |
| I've updated the patch to use unittest.mock, the removed the old style way of exercising it. |
|
|
| msg274989 - (view) |
Author: Senthil Kumaran (orsenthil) * |
Date: 2016-09-08 09:23 |
| Here is an updated patch that increases the coverage to 100% and has some pep8 style improvements. shannon-2: senthil$ ./python.exe -m test.regrtest test_dummy_thread Run tests sequentially 0:00:00 [1/1] test_dummy_thread 1 test OK. Total duration: 23 ms Tests result: SUCCESS shannon-2: senthil$ ./python.exe -m coverage run --pylib --source=_dummy_thread Lib/test/regrtest.py test_dummy_thread Run tests sequentially 0:00:00 [1/1] test_dummy_thread 1 test OK. Total duration: 82 ms Tests result: SUCCESS shannon-2: senthil$ ./python.exe -m coverage report --show-missing Name Stmts Miss Cover Missing ---------------------------------------------------- Lib/_dummy_thread.py 64 0 100% Since these are restricted to test improvements and have addressed the comments from previous reviews, I am going ahead with committing this patch. If there are any further comments, we can address them in subsequent commits. |
|
|
| msg274995 - (view) |
Author: Roundup Robot (python-dev)  |
Date: 2016-09-08 09:48 |
| New changeset 08f446bf45a7 by Senthil Kumaran in branch '3.5': Issue11551 - Increase the test coverage of _dummy_thread module to 100%. https://hg.python.org/cpython/rev/08f446bf45a7 New changeset d69e0df64b11 by Senthil Kumaran in branch 'default': [merge from 3.5] Issue11551 - Increase the test coverage of _dummy_thread module to 100%. https://hg.python.org/cpython/rev/d69e0df64b11 |
|
|