Issue 1163: Patch to make py3k/Lib/test/test_thread.py use unittest (original) (raw)

Issue1163

Created on 2007-09-13 20:44 by JonoDiCarlo, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
jdicarlo_stdlibtests_patch_sep7.diff JonoDiCarlo,2007-09-13 20:44
Messages (3)
msg55899 - (view) Author: Jono DiCarlo (JonoDiCarlo) Date: 2007-09-13 20:44
In the google spreadsheet for py3k tasks for the sprint last month, one of the listed tasks was to convert Lib/test/test_thread to use the unittest module, where it previously was using the old-style testing (i.e. comparing output of print statements to a text file). I'm attatching a patch that makes that change. This is my first time submitting a patch to Python, so please let me know if I'm doing anything wrong (or if this patch is redundant).
msg55918 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2007-09-14 19:53
This is a good start, but I think that instead of using global variables and functions, you should try to turn all those into instance variables (of the ThreadTest class). That way the tests are truly independent. Initialization should be taken care of in setUp().
msg63512 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2008-03-13 20:28
Closing as out of date as a GHOP attempt at this got farther and committed.
History
Date User Action Args
2022-04-11 14:56:26 admin set github: 45504
2008-03-13 20:28:11 brett.cannon set status: open -> closednosy: + brett.cannonresolution: out of datemessages: +
2007-09-18 12:29:18 jafo set priority: normal
2007-09-14 19:53:26 gvanrossum set nosy: + gvanrossummessages: +
2007-09-13 21:41:13 loewis set keywords: + patch
2007-09-13 20:44:44 JonoDiCarlo create