Issue 11743: Rewrite PipeConnection and Connection in pure Python (original) (raw)

Created on 2011-04-02 21:33 by pitrou, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
mpconn.patch pitrou,2011-04-02 21:32 review
pipebench.py pitrou,2011-04-03 16:03
mpconn2.patch pitrou,2011-05-07 16:53 review
Messages (8)
msg132816 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2011-04-02 21:32
Here is a rewrite of multiprocessing.{PipeConnection,Connection} in pure Python, for ease of maintenance and improvement.
msg132835 - (view) Author: Jesse Noller (jnoller) * (Python committer) Date: 2011-04-03 12:41
Nothing jumps out at me at initial review; I've asked other contributors/interested parties to take a look too. Thanks a ton Antoine for doing this work
msg132846 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2011-04-03 16:02
The patch slows down Pipe() a bit, by the way. On my machine, each message sent and received has an additional 10µs overhead. See attached benchmark script.
msg132848 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2011-04-03 16:03
Woops, sorry for the duplicates...
msg132881 - (view) Author: Ask Solem (asksol) (Python committer) Date: 2011-04-03 20:51
This is great! I always wondered if it was really necessary to use C for this. 10µs overhead should be worth it ;) I've read the patch, but not carefully. So far nothing jumps at me either. Cheers!
msg135480 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2011-05-07 16:53
Updated patch, fixing a sporadic failure in test_spawn_close.
msg135595 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2011-05-09 15:10
New changeset 1ac03e071d65 by Antoine Pitrou in branch 'default': Issue #11743: Rewrite multiprocessing connection classes in pure Python. http://hg.python.org/cpython/rev/1ac03e071d65
msg135597 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2011-05-09 15:13
Now checked in, hopefully there will be no buildbot failures.
History
Date User Action Args
2022-04-11 14:57:15 admin set github: 55952
2011-05-10 02:30:51 nirai set nosy: + nirai
2011-05-09 15:49:44 pitrou set status: pending -> closed
2011-05-09 15:13:08 pitrou set status: open -> pendingresolution: fixedmessages: + stage: patch review -> resolved
2011-05-09 15:10:42 python-dev set nosy: + python-devmessages: +
2011-05-07 16:53:50 pitrou set files: + mpconn2.patchmessages: +
2011-04-03 20:51:02 asksol set messages: +
2011-04-03 20:08:01 alex set nosy: + alex
2011-04-03 17:14:30 s7v7nislands set nosy: + s7v7nislands
2011-04-03 16:03:36 pitrou set messages: -
2011-04-03 16:03:30 pitrou set files: - mpconn.patch
2011-04-03 16:03:24 pitrou set messages: +
2011-04-03 16:03:05 pitrou set files: + pipebench.pymessages: +
2011-04-03 16:02:59 pitrou set files: + mpconn.patchmessages: +
2011-04-03 12:41:06 jnoller set messages: +
2011-04-02 21:40:00 pitrou link issue9205 dependencies
2011-04-02 21:33:00 pitrou create