Issue 11886: test_time.test_tzset() fails on "x86 FreeBSD 7.2 3.x": AEST timezone called "EST" (original) (raw)
Created on 2011-04-20 13:53 by vstinner, last changed 2022-04-11 14:57 by admin. This issue is now closed.
Messages (14)
Author: STINNER Victor (vstinner) * 
Date: 2011-04-20 13:53
test_time.test_tzset() fails on "x86 FreeBSD 7.2 3.x": 'AEST-10AEDT-11,M10.5.0,M3.5.0' timezone becomes 'EST'.
FAIL: test_tzset (test.test_time.TimeTestCase)
Traceback (most recent call last): File "/usr/home/db3l/buildarea/3.x.bolen-freebsd7/build/Lib/test/test_time.py", line 209, in test_tzset self.assertTrue(time.tzname[0] == 'AEST', str(time.tzname[0])) AssertionError: False is not true : EST
See also http://en.wikipedia.org/wiki/Time_in_Australia
Author: Alexander Belopolsky (belopolsky) *
Date: 2011-04-20 19:31
On Wed, Apr 20, 2011 at 9:53 AM, STINNER Victor <report@bugs.python.org> wrote: ..
test_time.test_tzset() fails on "x86 FreeBSD 7.2 3.x": 'AEST-10AEDT-11,M10.5.0,M3.5.0' timezone becomes 'EST'.
I was able to reproduce this error by faking a file named 'AEST-10AEDT-11,M10.5.0,M3.5.0' in /usr/share/zoneinfo/ on Mac OS X. (As far as I know, OSX is not that different from BSD with respect to basic posix interfaces.)
$ cd /usr/share/zoneinfo/ $ sudo cp EST AEST-10AEDT-11,M10.5.0,M3.5.0
Is it possible that the buildbot has such a file? What I find strange is that autoconf logic tests for working tzset using exactly the same TZ spec:
""" putenv("TZ=AEST-10AEDT-11,M10.5.0,M3.5.0"); tzset(); if (localtime(&groundhogday)->tm_hour != 11) exit(1); #if HAVE_TZNAME if (strcmp(tzname[0], "AEST") || strcmp(tzname[1], "AEDT")) exit(1); #endif """ See 'configure' script.
In other words, if TZ=AEST-10AEDT-11,M10.5.0,M3.5.0 breaks tzset, this should be detected at the configure stage and the tzset tests should be skipped. Is there a way to force configure run on the bot?
Author: STINNER Victor (vstinner) *
Date: 2011-11-24 15:17
Issue #13313 has been marked as a duplicate of this issue. Interesting message from flox:
"Maybe it is related. http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=93810
Ambiguous timezone names (AEST vs EST)"
Author: STINNER Victor (vstinner) *
Date: 2011-11-24 15:18
Is there a way to force configure run on the bot?
./configure is run for each build of each buildbot.
Author: STINNER Victor (vstinner) *
Date: 2011-11-24 15:27
I don't see this issue as a bug in Python, but just that the timezone database is different on some OSes. Can't we just accept both names, AEST and EST? Attached patch changes test_time to tolerate EST name for 'AEST-10AEDT-11,M10.5.0,M3.5.0' ("Victoria") time zone.
Author: STINNER Victor (vstinner) *
Date: 2011-12-05 22:06
Alex ? Florent ?
Author: Roundup Robot (python-dev) 
Date: 2011-12-07 23:32
New changeset c143e66e5efe by Victor Stinner in branch '3.2': Issue #11886: workaround an OS bug (time zone data) in test_time http://hg.python.org/cpython/rev/c143e66e5efe
New changeset c7638be1e430 by Victor Stinner in branch 'default': (Merge 3.2) Issue #11886: workaround an OS bug (time zone data) in test_time http://hg.python.org/cpython/rev/c7638be1e430
New changeset 2bca2cee79a1 by Victor Stinner in branch '2.7': Issue #11886: workaround an OS bug (time zone data) in test_time http://hg.python.org/cpython/rev/2bca2cee79a1
Author: STINNER Victor (vstinner) *
Date: 2011-12-09 20:28
The FreeBSD 7.2 3.x buildbot is green.
Author: Florent Xicluna (flox) *
Date: 2011-12-09 21:25
thank you for this fix. I agree a posteriori.
Author: Roundup Robot (python-dev)
Date: 2011-12-10 13:37
New changeset e37a7dc8944e by Victor Stinner in branch 'default': Issue #11886: Fix also test_time for the non-DST timezone name (EST/AEST) http://hg.python.org/cpython/rev/e37a7dc8944e
Author: STINNER Victor (vstinner) *
Date: 2011-12-12 01:06
Hum, it's still not ok:
====================================================================== FAIL: test_tzset (test.test_time.TimeTestCase)
Traceback (most recent call last): File "/usr/home/db3l/buildarea/3.x.bolen-freebsd7/build/Lib/test/test_time.py", line 264, in test_tzset self.assertEqual(time.timezone, -36000) AssertionError: 18000 != -36000
Author: Charles-François Natali (neologix) *
Date: 2011-12-14 18:33
Another failure on a 2.7 FreeBSD buildbot: """ test test_time failed -- Traceback (most recent call last): File "/usr/home/db3l/buildarea/2.7.bolen-freebsd7/build/Lib/test/test_time.py", line 193, in test_tzset self.assertTrue(time.tzname[1] == 'AEDT', str(time.tzname[1])) AssertionError: EDT """
http://www.python.org/dev/buildbot/all/builders/x86 FreeBSD 7.2 2.7/builds/859/steps/test/logs/stdio
Author: STINNER Victor (vstinner) *
Date: 2013-01-03 01:53
What is the status of this issue? Was the failure reproduced recently?
Author: Mark Lawrence (BreamoreBoy) *
Date: 2014-06-29 15:51
Can this be closed as "out of date"?
History
Date
User
Action
Args
2022-04-11 14:57:16
admin
set
github: 56095
2014-06-29 16:05:59
vstinner
set
status: open -> closed
resolution: fixed
2014-06-29 15:51:46
BreamoreBoy
set
nosy: + BreamoreBoy
messages: +
2013-01-03 01:53:25
vstinner
set
messages: +
2011-12-14 18:33:30
neologix
set
nosy: + neologix
messages: +
2011-12-12 01:06:46
vstinner
set
status: closed -> open
resolution: fixed -> (no value)
messages: +
2011-12-10 13:37:58
python-dev
set
messages: +
2011-12-09 21:25:49
flox
set
messages: +
2011-12-09 20:28:06
vstinner
set
status: open -> closed
resolution: fixed
messages: +
2011-12-07 23:32:59
python-dev
set
nosy: + python-dev
messages: +
2011-12-05 22:06:15
vstinner
set
messages: +
2011-11-24 15:27:34
vstinner
set
files: + time_aest.patch
keywords: + patch
messages: +
2011-11-24 15🔞35
vstinner
set
messages: +
2011-11-24 15:17:20
vstinner
set
nosy: + flox
messages: +
2011-04-20 19:31:11
belopolsky
set
messages: +
2011-04-20 13:53:12
vstinner
create