Issue 11961: Document STARTUPINFO and creationflags options for Windows (original) (raw)

Issue11961

Created on 2011-04-30 02:16 by brian.curtin, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
windows_additions.diff brian.curtin,2011-04-30 02:16 review
Messages (4)
msg134829 - (view) Author: Brian Curtin (brian.curtin) * (Python committer) Date: 2011-04-30 02:16
Attached is a patch that adds documentation for a few things that have existed in subprocess for a while without documentation. The "startupinfo" parameter takes subprocess.STARTUPINFO object which takes a few different options for its attributes, but none of this was documented. The "creationflags" parameter takes subprocess.CREATE_NEW_WINDOW or subprocess.CREATE_NEW_PROCESS_GROUP, but neither were documented as options or what the options mean.
msg134832 - (view) Author: Ezio Melotti (ezio.melotti) * (Python committer) Date: 2011-04-30 02:38
You can indent the "attribute" directives and avoid to repeat "STARTUPINFO." before every attribute. If STD_INPUT_HANDLE and the other constants are attributes of STARTUPINFO they should be indented too, otherwise a line that says that subprocess also provides those at module level might be better. Another short note at the beginning of the section that mentions that this class/attributes are available on Windows only would be good too. There's also some trailing whitespace that should be removed.
msg134835 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2011-04-30 03:24
New changeset 609ca9d71aba by Brian Curtin in branch '3.1': Fix #11961. Document STARTUPINFO and creation flag options. http://hg.python.org/cpython/rev/609ca9d71aba New changeset f0092c611004 by Brian Curtin in branch '3.2': Fix #11961. Document STARTUPINFO and creation flag options. http://hg.python.org/cpython/rev/f0092c611004 New changeset f8fae22a1ff0 by Brian Curtin in branch 'default': Fix #11961. Document STARTUPINFO and creation flag options. http://hg.python.org/cpython/rev/f8fae22a1ff0 New changeset 9a31422649f1 by Brian Curtin in branch '2.7': Fix #11961. Document STARTUPINFO and creation flag options. http://hg.python.org/cpython/rev/9a31422649f1
msg134836 - (view) Author: Brian Curtin (brian.curtin) * (Python committer) Date: 2011-04-30 03:26
Thanks for having a look, Ezio.
History
Date User Action Args
2022-04-11 14:57:16 admin set github: 56170
2011-04-30 03:26:19 brian.curtin set status: open -> closedresolution: fixedmessages: + stage: patch review -> resolved
2011-04-30 03:24:37 python-dev set nosy: + python-devmessages: +
2011-04-30 02:38:44 ezio.melotti set nosy: + ezio.melottimessages: +
2011-04-30 02:16:44 brian.curtin create