Issue 11970: distutils command 'upload' crashes when --show-response is selected (original) (raw)

When running distutils like so:

.tox/py27/bin/python setup.py -v bdist_egg upload --show-response

Eventually, after everything else spools by, this pops up:

Using PyPI login from /Users/offline/.pypirc Submitting dist/PyHamcrest-1.5-py2.7.egg to http://pypi.python.org/pypi Upload failed (401): You must be identified to edit package information Traceback (most recent call last): File "setup.py", line 69, in setup(**all_params) File "/usr/local/Cellar/python/2.7.1/lib/python2.7/distutils/core.py", line 152, in setup dist.run_commands() File "/usr/local/Cellar/python/2.7.1/lib/python2.7/distutils/dist.py", line 953, in run_commands self.run_command(cmd) File "/usr/local/Cellar/python/2.7.1/lib/python2.7/distutils/dist.py", line 972, in run_command cmd_obj.run() File "/usr/local/Cellar/python/2.7.1/lib/python2.7/distutils/command/upload.py", line 60, in run self.upload_file(command, pyversion, filename) File "/usr/local/Cellar/python/2.7.1/lib/python2.7/distutils/command/upload.py", line 193, in upload_file msg = '\n'.join(('-' * 75, r.read(), '-' * 75)) NameError: global name 'r' is not defined

I can see that this is only an error in the 2.7.1 release, and is fixed in distutils on the 2.7 branch (along with other bugs, too, from what I can see.)

I'm closing it as invalid, given that.

No, not 100% sure, but my read of the 2.7 branch code certainly seemed to suggest that it was fixed.

in distutil/commands/upload.py:

Line 193 gets the response unconditionally as 'r' from the http object

Line 201 uses 'r' to show the response.

I might be missing a form that the 'r' object can take that isn't going to have a read() method, but I doubt it.

... oh, except I'm an idiot, and I think I'm reading tip code there.

Yep, I'm an idiot.

Okay, but this is still a dupe of #10367