Issue 12045: external shell command executed twice in ctypes.util._get_soname (original) (raw)

Created on 2011-05-09 21:09 by pitrou, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Messages (6)
msg135650 - (view)	Author: Antoine Pitrou (pitrou) *	Date: 2011-05-09 21:09
It seems `cmd` is executed twice, for no obvious reason, in the following code: http://hg.python.org/cpython/file/2d4ef202d4ed/Lib/ctypes/util.py#l129
msg136125 - (view)	Author: Sijin Joseph (sijinjoseph)	Date: 2011-05-16 20:14
Attaching patch. Removed the second call to os.popen and used the dump variable that was read earlier as the argument to re.search.
msg136861 - (view)	Author: Roundup Robot (python-dev)	Date: 2011-05-25 16:17
New changeset c540b18b00b9 by Antoine Pitrou in branch 'default': Issue #12045: Avoid duplicate execution of command in ctypes.util._get_soname(). http://hg.python.org/cpython/rev/c540b18b00b9
msg136864 - (view)	Author: Antoine Pitrou (pitrou) *	Date: 2011-05-25 16:24
Committed, thank you!
msg265238 - (view)	Author: Martin Panter (martin.panter) *	Date: 2016-05-10 11:21
The same code is in Python 2. It was introduced by Issue 4861 (r68487).
msg265240 - (view)	Author: Roundup Robot (python-dev)	Date: 2016-05-10 11:41
New changeset 0b15b5371c07 by Antoine Pitrou in branch '2.7': Issue #12045: Avoid duplicate execution of command in ctypes.util._get_soname(). https://hg.python.org/cpython/rev/0b15b5371c07