| msg60756 - (view) |
Author: Björn Lindqvist (sonderblade) |
Date: 2005-06-10 13:49 |
| This is test.py: def foo(): print "Bla" And in an interactive session: >>> import inspect, test >>> test.foo() Bla >>> inspect.getsource(test.foo) 'def foo():\n print "Bla"\n' Now I edit test.py to (without exiting the interactive session): def foo(): print "Oh no!" >>> reload(test) <module 'test' from 'test.py'> >>> test.foo() Oh no! >>> inspect.getsource(test.foo) 'def foo():\n print "Bla"\n' inspect should output the new source. |
|
|
| msg60757 - (view) |
Author: Georg Brandl (georg.brandl) *  |
Date: 2005-06-10 16:36 |
| Logged In: YES user_id=1188172 This is the fault of the linecache module which inspect uses. It caches the file contents and does not reload it accordingly. However, I assume it's pretty hard finding a good solution to this. |
|
|
| msg62174 - (view) |
Author: Guilherme Polo (gpolo) * |
Date: 2008-02-07 19:42 |
| I'm attaching a patch. Is there some hidden problem that it may cause ? By the way, this issue is a duplicate of http://bugs.python.org/issue993580 |
|
|
| msg86540 - (view) |
Author: Daniel Diniz (ajaksu2) *  |
Date: 2009-04-25 19:38 |
| Fix was committed to py3k but with no tests AFAIK. Here's a (failing) test for trunk that runs OK after Guilherme's patch. We might want to keep this behavior restricted for when the module was reloaded. |
|
|
| msg86544 - (view) |
Author: Daniel Diniz (ajaksu2) * |
Date: 2009-04-25 20:08 |
| Er, no, it wasn't committed to py3k, it was just me getting my patches mixed. Attaching the py3k test with relative import fixed. |
|
|
| msg110435 - (view) |
Author: Mark Lawrence (BreamoreBoy) * |
Date: 2010-07-16 13:23 |
| The change to inspect.py is two lines. Given that unit test patches are also supplied could someone with the knowledge give yes or no to accepting this patch? |
|
|
| msg110436 - (view) |
Author: Jean-Paul Calderone (exarkun) * |
Date: 2010-07-16 13:27 |
| Calling linecache.checkcache for every inspect.getsource call sounds like a fairly bad idea to me. linecache.checkcache does a stat() of every single cached file. |
|
|
| msg110438 - (view) |
Author: Jean-Paul Calderone (exarkun) * |
Date: 2010-07-16 13:31 |
| > linecache.checkcache does a stat() of every single cached file. Ah, sorry. I didn't read carefully enough. I see that the patch passes in the filename and checkcache restricts the work it does in that case. Something else to consider, though, is that this change means you'll also get the new source if you *don't* reload the module, too. So, what exactly is inspect.getsource() supposed to be doing? Giving you the current on-disk contents of the relevant source file? Or giving you the actual source corresponding to the object passed to it? If the latter, then this actually needs to be more tightly integrated with module reloading somehow. |
|
|
| msg217951 - (view) |
Author: Jason R. Coombs (jaraco) * |
Date: 2014-05-05 20:18 |
| This issue appears implicated in https://bitbucket.org/pypa/setuptools/issue/201 |
|
|
| msg217990 - (view) |
Author: Yury Selivanov (yselivanov) * |
Date: 2014-05-06 15:33 |
| Thanks, I'll take a look at the patch. |
|
|
| msg217991 - (view) |
Author: R. David Murray (r.david.murray) * |
Date: 2014-05-06 15:57 |
| Note that there has never been a strict correspondence between linecache/getsource, the module in memory, and the code on disk. If the file is changed before a traceback is generated, for example, you will get the new source. That doesn't mean fixing the reload case is wrong, it's just something to keep in mind. |
|
|
| msg232328 - (view) |
Author: Roundup Robot (python-dev) |
Date: 2014-12-08 21:06 |
| New changeset 8e2505d535c8 by Yury Selivanov in branch 'default': inspect: Fix getsource() to load updated source of reloaded module https://hg.python.org/cpython/rev/8e2505d535c8 |
|
|
| msg232329 - (view) |
Author: Yury Selivanov (yselivanov) * |
Date: 2014-12-08 21:07 |
| Fixed in 3.5. Not sure if we need to backport this to 3.4 and 2.7. Closing this issue. Thanks to Björn Lindqvist and Berker Peksag! |
|
|
| msg232332 - (view) |
Author: Jason R. Coombs (jaraco) * |
Date: 2014-12-08 21:48 |
| FWIW, I'd appreciate a backport to 3.4, given that 3.5 is scheduled for release in Sep 2015. |
|
|
| msg232335 - (view) |
Author: Roundup Robot (python-dev) |
Date: 2014-12-08 23:01 |
| New changeset e52d8e888df1 by Yury Selivanov in branch '3.4': inspect: Fix getsource() to load updated source of reloaded module https://hg.python.org/cpython/rev/e52d8e888df1 |
|
|
| msg232336 - (view) |
Author: Yury Selivanov (yselivanov) * |
Date: 2014-12-08 23:10 |
| @Jason: done ;) |
|
|