Issue 12377: Clean up use of packages_root/package_dir (original) (raw)

Issue12377

Created on 2011-06-20 19:20 by erik.bray, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Messages (2)
msg138747 - (view)	Author: Erik Bray (erik.bray) *	Date: 2011-06-20 19:20
This issue was first mentioned in . The Distribution.package_dir attribute (which also appears in a few commands) is not used in a consistent manner. Some code expects it to be a string, while other code expects it to be a dict. I believe the correct behavior now is for it to be a string, since only one root directory for Python packages is allowed in packaging. Eric Araujo also points out that packages_root and the associated package_dir attribute are misnamed: They also point to the root for any Python modules. I'm not sure what a better name would be though--I'm tempted to suggest "source_dir", but that seems a little broad since it doesn't necessarily include C extension source.
msg138749 - (view)	Author: Éric Araujo (eric.araujo) *	Date: 2011-06-20 19:23
I would rename it modules_root, but a related discussion last summer showed that using “modules” to refer to pure Python modules, extension modules and Python packages was not 100% ideal for 100% of users.