Issue 12595: python.h redundant redeclarations (original) (raw)

Created on 2011-07-20 15:16 by verticalduck, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
issue12595.patch petri.lehtinen,2011-07-27 18:33
Messages (5)
msg140746 - (view) Author: Tobias Pfaff (verticalduck) Date: 2011-07-20 15:16
Compiling 'Python.h' with g++ and -Wredundant-decls produces warnings Testcase: test.cpp: #include <Python.h> int main() { return 0; } g++ test.cpp -I/usr/include/python3.2mu/ -Wredundant-decls In file included from /usr/include/python3.2mu/Python.h:106, from test.cpp:1: /usr/include/python3.2mu/pyerrors.h:73: warning: redundant redeclaration of ‘void Py_FatalError(const char*)’ in same scope /usr/include/python3.2mu/pydebug.h:29: warning: previous declaration of ‘void Py_FatalError(const char*)’
msg141219 - (view) Author: Petri Lehtinen (petri.lehtinen) * (Python committer) Date: 2011-07-27 11:17
Already fixed in 3.3 as a part of issue 8914. This does not cause a compilation failure with the default build flags, so there's no need to backport to older versions. Closing as duplicate of issue 8914.
msg141220 - (view) Author: Petri Lehtinen (petri.lehtinen) * (Python committer) Date: 2011-07-27 11:19
After hitting the submit button, I realized that Python.h is of course included when embedding Python, so the fix could be backported to 3.2.
msg141258 - (view) Author: Petri Lehtinen (petri.lehtinen) * (Python committer) Date: 2011-07-27 18:33
Attached a partial patch for from issue 8914 that should deal with this issue in 3.2.
msg141309 - (view) Author: Petri Lehtinen (petri.lehtinen) * (Python committer) Date: 2011-07-28 17:55
Barry Warsaw wrote: > I don't feel comfortable changing what is defined in > a header file in a point release, so I am not going > to backport the fix. Closing as wont fix.
History
Date User Action Args
2022-04-11 14:57:19 admin set github: 56804
2011-07-28 17:55:47 petri.lehtinen set status: open -> closedmessages: + keywords: + needs reviewresolution: wont fixstage: needs patch -> patch review
2011-07-27 18:33:33 petri.lehtinen set files: + issue12595.patchkeywords: + patchmessages: +
2011-07-27 11:19:24 petri.lehtinen set status: closed -> opensuperseder: Run clang's static analyzer -> messages: + keywords: + easyresolution: duplicate -> (no value)stage: needs patch
2011-07-27 11:17:55 petri.lehtinen set status: open -> closednosy: + petri.lehtinenmessages: + superseder: Run clang's static analyzerresolution: duplicate
2011-07-20 15:16:31 verticalduck create