Issue 12656: test.test_asyncore: add tests for AF_INET6 and AF_UNIX sockets (original) (raw)

Issue12656

Created on 2011-07-29 18:00 by neologix, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
test_ayncore.diff neologix,2011-07-30 12:10 review
test_ayncore-1.diff neologix,2011-08-24 21:02 review
Messages (7)
msg141404 - (view) Author: Charles-François Natali (neologix) * (Python committer) Date: 2011-07-29 18:00
As noted in issue #12502, test_asyncore only tests AF_INET sockets. With the patch attached, the vast majority of the tests will also be run with AF_UNIX and AF_INET6 sockets (if supported by the host OS).
msg142908 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2011-08-24 20:10
Perhaps bind_af_aware() should find its place in test.support. Also, using test.support.unlink means it filters out acceptable errnos. Also, do we want an IPv6 test with poll, or is it overkill?
msg142921 - (view) Author: Charles-François Natali (neologix) * (Python committer) Date: 2011-08-24 21:02
New patch. > Perhaps bind_af_aware() should find its place in test.support. I'm not sure, it's really specific to this test. > Also, using test.support.unlink means it filters out acceptable errnos. Thanks, I didn't know about this. > Also, do we want an IPv6 test with poll, or is it overkill? Let's add it (especially since test_asyncore is really fast).
msg142922 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2011-08-24 21:04
Looks good to me :)
msg142926 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2011-08-24 21:22
New changeset b07b0b7517da by Charles-François Natali in branch 'default': Issue #12656: Add tests for IPv6 and Unix sockets to test_asyncore. http://hg.python.org/cpython/rev/b07b0b7517da
msg142939 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2011-08-24 22:49
New changeset 603025e2d39d by Charles-François Natali in branch 'default': Issue #12656: Fix test_asyncore failures on Windows buildbots. http://hg.python.org/cpython/rev/603025e2d39d
msg142949 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2011-08-24 23:21
New changeset f3444d795062 by Charles-François Natali in branch 'default': Issue #12656: Really fix test_asyncore failures on Windows buildbots... http://hg.python.org/cpython/rev/f3444d795062
History
Date User Action Args
2022-04-11 14:57:20 admin set github: 56865
2011-08-25 17:22:16 neologix set status: open -> closedresolution: fixedstage: patch review -> resolved
2011-08-24 23:21:38 python-dev set messages: +
2011-08-24 22:49:30 python-dev set messages: +
2011-08-24 21:22:58 python-dev set nosy: + python-devmessages: +
2011-08-24 21:04:57 pitrou set messages: +
2011-08-24 21:02:07 neologix set files: + test_ayncore-1.diffmessages: +
2011-08-24 20:10:06 pitrou set messages: +
2011-08-24 19:45:40 neologix set nosy: + pitrou, vstinner
2011-07-30 12:10:38 neologix set files: - test_ayncore.diff
2011-07-30 12:10:27 neologix set files: + test_ayncore.diff
2011-07-29 18:00:09 neologix create