Issue 13016: selectmodule.c: refleak - Python tracker (original) (raw)

Issue13016

Created on 2011-09-20 14:54 by Suman.Saha, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
python_patch4 Suman.Saha,2011-09-20 14:54 Patch review
Messages (2)
msg144333 - (view) Author: Suman Saha (Suman.Saha) Date: 2011-09-20 14:54
Something that is allocated using PySequence_Fast is not freed on one error path.
msg146387 - (view) Author: Petri Lehtinen (petri.lehtinen) * (Python committer) Date: 2011-10-25 18:25
PySequence_Fast_GET_ITEM expects that the object is valid and the index is within bounds, and never returns NULL. There's no need to decref and actually there's even no need to check the return value of PySequence_Fast_GET_ITEM.
History
Date User Action Args
2022-04-11 14:57:21 admin set github: 57225
2011-10-25 18:25:47 petri.lehtinen set status: open -> closedresolution: rejectedmessages: + stage: patch review -> resolved
2011-10-24 07:04:35 petri.lehtinen set keywords: + patch, needs reviewnosy: + petri.lehtinen
2011-09-21 19:31:49 skrah set title: Resource is not released before returning from the functiion -> selectmodule.c: refleakstage: patch reviewcomponents: + Extension Modulesversions: + Python 3.3
2011-09-20 14:54:33 Suman.Saha create