Issue 13076: Bad links to 'time' in datetime documentation (original) (raw)

Created on 2011-09-30 13:45 by gjb1002, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
issue13076.diff ezio.melotti,2011-10-02 08:18 Patch to reference datetime.time explicitly.
Messages (5)
msg144689 - (view) Author: Geoffrey Bache (gjb1002) Date: 2011-09-30 13:45
Reading through the datetime module documentation, various places that refer to "datetime.time" objects are in fact links to the "time" module. They should refer to the appropriate section on the same page.
msg144761 - (view) Author: Ezio Melotti (ezio.melotti) * (Python committer) Date: 2011-10-02 08:18
The broken links seem to be only in the "time objects" section, and only in the body of attribute/method directives. The attached patch fixes the issue by using :class:`~datetime.time` explicitly where the links are broken. Georg, is this a bug in Sphinx?
msg144762 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2011-10-02 08:23
No, it's not, it's how Sphinx works. Use :class:`.time` to refer to the datetime class.
msg144766 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2011-10-02 09:47
New changeset 854e31d80151 by Ezio Melotti in branch '2.7': #13076: fix links to datetime.time. http://hg.python.org/cpython/rev/854e31d80151 New changeset 95689ed69097 by Ezio Melotti in branch '3.2': #13076: fix links to datetime.time and datetime.datetime. http://hg.python.org/cpython/rev/95689ed69097 New changeset 175cd2a51ea9 by Ezio Melotti in branch 'default': #13076: merge with 3.2. http://hg.python.org/cpython/rev/175cd2a51ea9
msg144768 - (view) Author: Ezio Melotti (ezio.melotti) * (Python committer) Date: 2011-10-02 09:49
This should be fixed now, thanks for the report. FTR with Sphinx 1.0 all the links to :class:`time` and also :class:`datetime` needed to be fixed because they were pointing to the modules, with 0.6 only the :class:`time` in the body of attribute/method directives were broken.
History
Date User Action Args
2022-04-11 14:57:22 admin set github: 57285
2011-10-02 09:49:51 ezio.melotti set status: open -> closedresolution: fixedmessages: + stage: patch review -> resolved
2011-10-02 09:47:24 python-dev set nosy: + python-devmessages: +
2011-10-02 08:23:17 georg.brandl set messages: +
2011-10-02 08🔞23 ezio.melotti set files: + issue13076.diffassignee: docs@python -> ezio.melottikeywords: + patchnosy: + georg.brandl, ezio.melottimessages: + stage: needs patch -> patch review
2011-09-30 13:48:03 r.david.murray set stage: needs patchversions: - Python 2.6, Python 3.1, Python 3.4
2011-09-30 13:45:45 gjb1002 set assignee: docs@pythoncomponents: + Documentationnosy: + docs@python
2011-09-30 13:45:08 gjb1002 create