Issue 13100: sre_compile._optimize_unicode() needs a cleanup (original) (raw)

Issue13100

Created on 2011-10-04 17:11 by vstinner, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Messages (3)
msg144905 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2011-10-04 17:11
The following comment is wrong, except IndexError: # non-BMP characters; XXX now they should work return charset sys.maxunicode != 65535 is now always true in Python 3.3 if sys.maxunicode != 65535: # XXX: negation does not work with big charsets # XXX2: now they should work, but removing this will make the # charmap 17 times bigger return charset See the related commit: f39b26ca7f3d (from issue #13054).
msg178896 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2013-01-03 02:02
I don't know what to do with this issue. The code looks to work anyway, so I guess that it's safer to not touch it :-)
msg200753 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2013-10-21 11:46
There are a lot of dead or suboptimal code in the re module. For example _sre.CODESIZE now can't be 2. We could cleanup the code as side effect of optimization.
History
Date User Action Args
2022-04-11 14:57:22 admin set github: 57309
2013-10-21 11:46:00 serhiy.storchaka set nosy: + serhiy.storchakamessages: +
2013-01-03 04:40:30 ezio.melotti set nosy: + mrabarnetttype: behaviorstage: resolved
2013-01-03 02:02:38 vstinner set status: open -> closedresolution: wont fixmessages: +
2011-10-04 17:11:58 vstinner create