Issue 13291: latent NameError in xmlrpc package (original) (raw)

There's two names which should be fixed in "xmlrpc" package:

--- a/Lib/xmlrpc/client.py

   elif isinstance(other, (str, unicode)):

--- a/Lib/xmlrpc/server.py

```
       response = xmlrpclib.dumps(
```

           xmlrpclib.Fault(1, "%s:%s" % (exc_type, exc_value)),

We may extend test coverage too.

Apparently buildbot failures are caused by this commit:

====================================================================== ERROR: test_datetime_before_1900 (test.test_xmlrpc.XMLRPCTestCase)

Traceback (most recent call last): File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_xmlrpc.py", line 62, in test_datetime_before_1900 (newdt,), m = xmlrpclib.loads(s, use_datetime=1) File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/xmlrpc/client.py", line 969, in loads p.feed(data) File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/xmlrpc/client.py", line 430, in feed self._parser.Parse(data, 0) File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/xmlrpc/client.py", line 662, in end return f(self, "".join(self._data)) File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/xmlrpc/client.py", line 745, in end_dateTime value = _datetime_type(data) File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/xmlrpc/client.py", line 359, in _datetime_type return datetime.strptime(data, "%Y%m%dT%H:%M:%S") File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/_strptime.py", line 488, in _strptime_datetime tt, fraction = _strptime(data_string, format) File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/_strptime.py", line 337, in _strptime (data_string, format)) ValueError: time data '10210T11:41:23' does not match format '%Y%m%dT%H:%M:%S'

http://www.python.org/dev/buildbot/all/builders/x86%20Ubuntu%20Shared%203.x/builds/4704