Issue 13325: no address in the representation of asyncore dispatcher after connection established (original) (raw)

When an asyncore dispatcher initiates a tcp connection, its representation lacks the peer address. The output of the attached script 'dispatcher_addr.py' gives on linux with Python 3.2:

call stack in handle_connect_event: ->main->loop->poll->write->handle_write_event->handle_connect_event self.addr after connection: None

The attached patch fixes the problem. The patch includes a test case. The following comment in the patch:

# EWOULDBLOCK may also be returned by winsock when calling connect
# while the connection attempt is in progress

refers to the following statement in http://msdn.microsoft.com/en-us/library/aa923167.aspx

""" As a result, it is not recommended that applications use multiple calls to connect to detect connection completion. If they do, they must be prepared to handle WSAEINVAL and WSAEWOULDBLOCK error codes the same way that they handle WSAEALREADY to ensure robust execution. """

Note that two consecutive calls to socket.getsockopt(socket.SOL_SOCKET, socket.SO_ERROR) are made when handle_write_event() is called and self.connected is False: one in handle_write_event and the following right away in handle_connect_event. This seems useless.