Issue 1341: correction for test_fileinput in py3k on Windows (original) (raw)

Issue1341

Created on 2007-10-26 23:59 by amaury.forgeotdarc, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
fileinput.diff amaury.forgeotdarc,2007-10-26 23:59
Messages (2)
msg56833 - (view) Author: Amaury Forgeot d'Arc (amaury.forgeotdarc) * (Python committer) Date: 2007-10-26 23:59
This patch corrects test_fileinput on Windows: when redirecting stdout, os.open should be given O_BINARY, because the file descriptor is then wrapped in a text-mode file; os.fdopen(fd, "w").
msg56915 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2007-10-29 17:40
Thanks, good catch! Committed revision 58704. (in the py3k branch)
History
Date User Action Args
2022-04-11 14:56:27 admin set github: 45682
2007-10-29 17:40:14 gvanrossum set status: open -> closedresolution: acceptedmessages: + nosy: + gvanrossum
2007-10-27 06:43:30 loewis set keywords: + patch
2007-10-27 00:00:36 amaury.forgeotdarc set components: + Windowsversions: + Python 3.0
2007-10-26 23:59:30 amaury.forgeotdarc create