Issue 1345: Fix for test_netrc on Windows (original) (raw)

Issue1345

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

This issue has been migrated to GitHub: https://github.com/python/cpython/issues/45686

classification

process

Created on 2007-10-27 21:45 by christian.heimes, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (3)
msg56863 - (view)	Author: Christian Heimes (christian.heimes) *	Date: 2007-10-27 21:45
Index: Lib/test/test_netrc.py =================================================================== --- Lib/test/test_netrc.py (revision 58695) +++ Lib/test/test_netrc.py (working copy) @@ -25,7 +25,7 @@ mode = 'w' if sys.platform not in ['cygwin']: mode += 't' - fp = open(temp_filename, mode) + fp = open(temp_filename, mode, newline='') fp.write(TEST_NETRC) fp.close()
msg56917 - (view)	Author: Guido van Rossum (gvanrossum) *	Date: 2007-10-29 17:51
Are you sure this is the proper fix? Why does netrc.py insist on not having \r\n line endings? It opens the file in text mode so I don't quite understand your patch.
msg56960 - (view)	Author: Christian Heimes (christian.heimes) *	Date: 2007-10-30 12:18
Guido van Rossum wrote: > Are you sure this is the proper fix? Why does netrc.py insist on not > having \r\n line endings? It opens the file in text mode so I don't > quite understand your patch. I don't quite understand why it fails. :/ I've to take more time to debug it. Christian