Issue 13563: Make use of with statement in ftplib (original) (raw)
Issue13563
Created on 2011-12-09 05:21 by giampaolo.rodola, last changed 2022-04-11 14:57 by admin. This issue is now closed.
| Files |
|
|
|
| File name |
Uploaded |
Description |
Edit |
| ftplib.patch |
giampaolo.rodola,2011-12-09 05:21 |
review |
|
| Messages (4) |
|
|
| msg149074 - (view) |
Author: Giampaolo Rodola' (giampaolo.rodola) *  |
Date: 2011-12-09 05:21 |
| Patch in attachment. |
|
|
| msg149083 - (view) |
Author: Antoine Pitrou (pitrou) * |
Date: 2011-12-09 10:05 |
| The first hunk of the patch doesn't look right: ntransfercmd() is supposed to return the connection but the "with" statement closes it. |
|
|
| msg149185 - (view) |
Author: Roundup Robot (python-dev)  |
Date: 2011-12-10 20:25 |
| New changeset 6cd736239b8a by Giampaolo Rodola' in branch 'default': fix #13563: make use of with statement in ftplib.py where needed http://hg.python.org/cpython/rev/6cd736239b8a |
|
|
| msg149186 - (view) |
Author: Giampaolo Rodola' (giampaolo.rodola) * |
Date: 2011-12-10 20:26 |
| That's why I nosyed you. Thanks. ;) |
|
|
| History |
|
|
|
| Date |
User |
Action |
Args |
| 2022-04-11 14:57:24 |
admin |
set |
github: 57772 |
| 2011-12-10 20:26:13 |
giampaolo.rodola |
set |
status: open -> closedmessages: + assignee: giampaolo.rodolacomponents: + Library (Lib)keywords: + easy, - patchresolution: fixed |
| 2011-12-10 20:25:10 |
python-dev |
set |
nosy: + python-devmessages: + |
| 2011-12-09 10:05:23 |
pitrou |
set |
messages: + |
| 2011-12-09 05:21:50 |
giampaolo.rodola |
create |
|