Issue 13867: misleading comment in weakrefobject.h (original) (raw)
Issue13867
Created on 2012-01-25 23:01 by Jim.Jewett, last changed 2022-04-11 14:57 by admin. This issue is now closed.
| Messages (5) | ||
|---|---|---|
| msg151983 - (view) | Author: Jim Jewett (Jim.Jewett) *  |
Date: 2012-01-25 23:01 |
| http://hg.python.org/cpython/file/fec45282dc28/Include/weakrefobject.h#l54 The comment makes sense -- but doesn't appear to be true, so perhaps it is the macro that should change. /* This macro calls PyWeakref_CheckRef() last since that can involve a function call; this makes it more likely that the function call will be avoided. */ #define PyWeakref_Check(op) \ (PyWeakref_CheckRef(op) | | PyWeakref_CheckProxy(op)) | |
| msg152142 - (view) | Author: Antoine Pitrou (pitrou) *  |
Date: 2012-01-27 23:39 |
| Ha, good catch. The macro could be fixed, or the comment simply be dropped. | ||
| msg199229 - (view) | Author: Roundup Robot (python-dev) |
Date: 2013-10-08 18:26 |
| New changeset 1800107873c0 by Georg Brandl in branch 'default': Closes #13867: remove untrue comment about PyWeakref_Check(). http://hg.python.org/cpython/rev/1800107873c0 | ||
| msg199231 - (view) | Author: Roundup Robot (python-dev) |
Date: 2013-10-08 18:32 |
| New changeset 1cd2fca12abf by Georg Brandl in branch '3.3': Closes #13867: remove untrue comment about PyWeakref_Check(). http://hg.python.org/cpython/rev/1cd2fca12abf | ||
| msg199232 - (view) | Author: Roundup Robot (python-dev) |
Date: 2013-10-08 18:33 |
| New changeset 39e5ab118602 by Georg Brandl in branch '2.7': Closes #13867: remove untrue comment about PyWeakref_Check(). http://hg.python.org/cpython/rev/39e5ab118602 |
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:57:26 | admin | set | github: 58075 |
| 2013-10-08 18:33:01 | python-dev | set | messages: + |
| 2013-10-08 18:32:07 | python-dev | set | messages: + |
| 2013-10-08 18:26:55 | python-dev | set | status: open -> closednosy: + python-devmessages: + resolution: fixedstage: resolved |
| 2012-01-27 23:39:52 | pitrou | set | messages: + versions: + Python 2.7, Python 3.2, Python 3.3 |
| 2012-01-27 23:36:27 | terry.reedy | set | nosy: + fdrake, pitroucomponents: + Library (Lib), - Documentation, Extension Modules |
| 2012-01-25 23:01:15 | Jim.Jewett | create |