Issue 13950: rm commented-out code (original) (raw)

Issue13950

Created on 2012-02-06 08:32 by tshepang, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
rm-commented-out-code.patch tshepang,2012-02-06 08:32 review
Messages (3)
msg152727 - (view) Author: Tshepang Lekhonkhobe (tshepang) * Date: 2012-02-06 08:32
It does not appear that the commented-out code adds any value. If anything, it's maybe just a distraction.
msg152736 - (view) Author: Éric Araujo (eric.araujo) * (Python committer) Date: 2012-02-06 14:34
Before Tarek started the distutils2 project, the version code lived standalone and its README file served as doctest. Most of its text was moved to PEP 386 and the tests themselves to test_verlib (and now test_version): https://bitbucket.org/tarek/distutilsversion/changeset/140170ef3896#chg-README.txt So you’re right, the lines that your patch removes are indeed unneeded, but I’d just like to check that all tests were moved into test_version before applying it.
msg153152 - (view) Author: Éric Araujo (eric.araujo) * (Python committer) Date: 2012-02-12 03:44
Done as part of my general cleanup of test_version.
History
Date User Action Args
2022-04-11 14:57:26 admin set github: 58158
2012-06-25 12:09:03 ned.deily set messages: -
2012-06-25 12:05:48 python-dev set nosy: + python-devmessages: +
2012-02-12 03:44:44 eric.araujo set status: open -> closedresolution: duplicatemessages: + superseder: Get rid of doctests in packaging.tests.test_versionstage: resolved
2012-02-06 14:34:21 eric.araujo set assignee: tarek -> eric.araujomessages: + versions: + 3rd party
2012-02-06 08:32:26 tshepang create