Issue 13969: path name must always be string (or None) (original) (raw)

Issue13969

Created on 2012-02-08 11:56 by tshepang, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
path-name-must-be-string-or-None.patch tshepang,2012-02-08 11:56 review
Messages (2)
msg152845 - (view) Author: Tshepang Lekhonkhobe (tshepang) * Date: 2012-02-08 11:56
I was writing a test that could return True for "if not pathname" (http://hg.python.org/cpython/file/58bd6a58365d/Lib/packaging/util.py#l109), and included all values I know that could return a False value, but then I realised that the only value we should check against is an empty string... I don't think any other type is applicable. I left None as a valid type, otherwise some other test (test_command_install_dist.py) fails.
msg152883 - (view) Author: Éric Araujo (eric.araujo) * (Python committer) Date: 2012-02-08 16:32
Hm, that function is for internal use only, and our code always passes a string, so I’m not sure a type check is useful.
History
Date User Action Args
2022-04-11 14:57:26 admin set github: 58177
2014-03-13 02:37:31 eric.araujo set status: open -> closedresolution: out of datestage: resolved
2012-02-08 16:32:04 eric.araujo set messages: +
2012-02-08 12:28:55 tshepang set nosy: + eric.araujo, alexis, tarektitle: path name must always be string -> path name must always be string (or None)assignee: tarekversions: + Python 3.3components: + Distutils2
2012-02-08 11:56:37 tshepang create