Logged In: YES user_id=764593 Are you sure these were just compiler-related? Changing things like frequency from {0,0} to {{0,}} or adding parentheses strike me as at least possible bugfixes that should not be in #ifdefs
Logged In: YES user_id=700047 Most of the changes were related to correct usage of braces and incompatibilities with mingw (note that i compiled with msvc too). The parenthesis changes apply to msvc too. I thank you so much for paying attention on this.
Logged In: YES user_id=21627 Unfortunately, the patch is unacceptable in its current form. Some of the changes seem essential to make Python work with Mingw, others seem merely aesthetical (i.e. those that make warnings go away). Some of the changes that make warnings go away look wrong: the code is right as it stands, and if you get a warning with MingW, it's either that the compiler is wrong, or some other part of the setup is broken. Would you be willing to rework the patch to only include the fragments that are absolutely necessary to make it compile and work correctly? Also, it would be much more useful if you could forward-port the patch to the 2.5 subversion trunk. Among the things I consider faulty are: - inclusion of wincrypt.h - addition of a parenthesis around the cFileName[1/2] block - explicit conversion of arguments to const char**
