Issue 14184: test_recursion_limit fails on OS X when compiled with clang (original) (raw)

Created on 2012-03-03 18:24 by dk, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
test dk,2012-03-03 18:26
issue14184.patch ned.deily,2012-03-12 22:55 review
issue14184_rev1.patch ned.deily,2012-03-13 01:06 review
Messages (5)
msg154844 - (view) Author: Dionysios Kalofonos (dk) * Date: 2012-03-03 18:26
python compiled with ./configure --with-pydebug CC=clang MACOSX_DEPLOYMENT_TARGET=10.7 make EXTRA_CFLAGS="-Wno-unused-value -Wno-empty-body -Qunused-arguments"
msg155508 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2012-03-12 22:55
3.2 also fails when compiled on 10.7 with clang. Issue9670 had increased the secondary stack size for OS X and FreeBSD by an empirically-determined amount to reduce the chance of crashes for recursive function calls. Continuing that somewhat kludgey strategy, the attached patch increases the stack size on OS X to a value such that the test no longer crashes. It also separates the values for FreeBSD and OS X.
msg155549 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2012-03-13 01:06
It looks like the increase isn't quite big enough for the clang in Xcode 4.2. Revised patch uses a slightly bigger size.
msg155641 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2012-03-13 18:33
New changeset 246e681a4272 by Ned Deily in branch '3.2': Issue #14184: Increase the default stack size for secondary threads on http://hg.python.org/cpython/rev/246e681a4272 New changeset c00ac2b25048 by Ned Deily in branch 'default': Issue #14184: merge http://hg.python.org/cpython/rev/c00ac2b25048
msg155642 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2012-03-13 18:36
Thanks for the report. Fix applied for 3.2.x (for release in 3.2.4) and default (for 3.3.0).
History
Date User Action Args
2022-04-11 14:57:27 admin set github: 58392
2012-03-13 18:36:29 ned.deily set status: open -> closedtype: crashmessages: + resolution: fixedstage: patch review -> resolved
2012-03-13 18:33:11 python-dev set nosy: + python-devmessages: +
2012-03-13 01:06:23 ned.deily set files: + issue14184_rev1.patchmessages: +
2012-03-12 22:55:19 ned.deily set files: + issue14184.patchversions: + Python 3.2messages: + keywords: + patchstage: needs patch -> patch review
2012-03-05 04:51:16 meador.inge set nosy: + meador.inge
2012-03-04 02:35:05 ned.deily set assignee: ned.deilynosy: + ned.deilystage: needs patchtitle: test_recursion_limit -> test_recursion_limit fails on OS X when compiled with clang
2012-03-03 18:26:13 dk set files: + testmessages: + components: + Testsversions: + Python 3.3
2012-03-03 18:24:10 dk create