Issue 14546: lll.py can't handle multiple parameters correctly (original) (raw)
Created on 2012-04-11 14:29 by carton, last changed 2022-04-11 14:57 by admin. This issue is now closed.
Files | |||
---|---|---|---|
File name | Uploaded | Description | Edit |
lll.py.patch | carton,2012-04-11 14:29 | Patch file | review |
Pull Requests | |||
---|---|---|---|
URL | Status | Linked | Edit |
PR 13026 | merged | ZackerySpytz,2019-04-30 20:34 | |
PR 13060 | merged | miss-islington,2019-05-02 16:34 | |
PR 13063 | merged | ZackerySpytz,2019-05-02 17:49 |
Messages (9) | ||
---|---|---|
msg158036 - (view) | Author: Carton He (carton) | Date: 2012-04-11 14:29 |
Space errors in calling of lll(arg) of main() cause it only applies to the last parameter instead of all parameters. Patch attached for Python 3.1 | ||
msg158037 - (view) | Author: R. David Murray (r.david.murray) * ![]() |
Date: 2012-04-11 14:36 |
Thanks for the patch. Do you have any interest in writing a test for this? Tests for tools go in Lib/test/test_tools.py. | ||
msg341161 - (view) | Author: Zackery Spytz (ZackerySpytz) * ![]() |
Date: 2019-04-30 20:36 |
I've created a PR for this issue (with a test). | ||
msg341269 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * ![]() |
Date: 2019-05-02 15:04 |
New changeset c4e78b116f9a4299f3b3bfbbd18ef49782bb1143 by Serhiy Storchaka (Zackery Spytz) in branch 'master': bpo-14546: Fix the argument handling in Tools/scripts/lll.py (GH-13026) https://github.com/python/cpython/commit/c4e78b116f9a4299f3b3bfbbd18ef49782bb1143 | ||
msg341275 - (view) | Author: STINNER Victor (vstinner) * ![]() |
Date: 2019-05-02 15:20 |
test_tools: test_lll_multiple_dirs() failed on AMD64 Windows7 SP1 3.x: see bpo-36776. | ||
msg341276 - (view) | Author: STINNER Victor (vstinner) * ![]() |
Date: 2019-05-02 15:22 |
> test_tools: test_lll_multiple_dirs() failed on AMD64 Windows7 SP1 3.x: see bpo-36776. I guess that the test should be decorated by @support.skip_unless_symlink or something like that. | ||
msg341308 - (view) | Author: STINNER Victor (vstinner) * ![]() |
Date: 2019-05-02 19:29 |
New changeset e85ba1e69288e3fce400ed4cdbefab58934b5904 by Victor Stinner (Miss Islington (bot)) in branch '3.7': [3.7] bpo-14546: Fix the argument handling in Tools/scripts/lll.py (GH-13026) (GH-13060) https://github.com/python/cpython/commit/e85ba1e69288e3fce400ed4cdbefab58934b5904 | ||
msg341309 - (view) | Author: STINNER Victor (vstinner) * ![]() |
Date: 2019-05-02 19:29 |
New changeset 7c2c01f02a1821298a62dd16ecc3a12da663e14b by Victor Stinner (Zackery Spytz) in branch '2.7': [2.7] bpo-14546: Fix the argument handling in Tools/scripts/lll.py (GH-13026) (GH-13063) https://github.com/python/cpython/commit/7c2c01f02a1821298a62dd16ecc3a12da663e14b | ||
msg341310 - (view) | Author: STINNER Victor (vstinner) * ![]() |
Date: 2019-05-02 19:30 |
Thanks Carton He for the bug report, thanks Zackery Spytz for the fix, thanks Serhiy Storchaka for the review ;-) |
History | |||
---|---|---|---|
Date | User | Action | Args |
2022-04-11 14:57:29 | admin | set | github: 58751 |
2019-05-02 19:30:04 | vstinner | set | status: open -> closedresolution: fixedmessages: + stage: patch review -> resolved |
2019-05-02 19:29:24 | vstinner | set | messages: + |
2019-05-02 19:29:10 | vstinner | set | messages: + |
2019-05-02 17:49:46 | ZackerySpytz | set | pull_requests: + <pull%5Frequest12980> |
2019-05-02 16:34:56 | miss-islington | set | pull_requests: + <pull%5Frequest12977> |
2019-05-02 15:22:11 | vstinner | set | messages: + |
2019-05-02 15:20:35 | vstinner | set | nosy: + vstinnermessages: + |
2019-05-02 15:04:04 | serhiy.storchaka | set | nosy: + serhiy.storchakamessages: + |
2019-04-30 20:36:28 | ZackerySpytz | set | nosy: + ZackerySpytzmessages: + versions: + Python 3.7, Python 3.8, - Python 3.2, Python 3.3 |
2019-04-30 20:34:49 | ZackerySpytz | set | stage: test needed -> patch reviewpull_requests: + <pull%5Frequest12948> |
2012-04-11 14:36:45 | r.david.murray | set | versions: + Python 3.2, Python 3.3, - Python 3.4nosy: + r.david.murraymessages: + type: behaviorstage: test needed |
2012-04-11 14:29:36 | carton | create |