Issue 14585: Have test_import run more importlib tests (original) (raw)

Issue14585

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

This issue has been migrated to GitHub: https://github.com/python/cpython/issues/58790

classification

Title: Have test_import run more importlib tests
Type: Stage: resolved
Components: Tests Versions: Python 3.3

process

Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: brett.cannon Nosy List: berker.peksag, brett.cannon, eric.snow, python-dev
Priority: normal Keywords: easy

Created on 2012-04-15 01:27 by brett.cannon, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Messages (3)
msg158306 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2012-04-15 01:27
As it stands, test_import runs importlib.test.import_.test_relative_imports. It would probably be better to have test_import run all importlib tests using __import__(), especially since it is already coded up in importlib.test.__main__ to do so. In all honesty I'm willing to bet there is some duplication in test_import that can just go away if someone put the time in to try to prune the file down.
msg158347 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2012-04-15 18:18
This also means that the importlib.test.import_.util.importlib_only decorators are probably all useless.
msg158878 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2012-04-20 19:52
New changeset a74ba7407457 by Brett Cannon in branch 'default': Issue #14585: test_import now runs all tests under http://hg.python.org/cpython/rev/a74ba7407457
History
Date User Action Args
2022-04-11 14:57:29 admin set github: 58790
2012-04-20 19:52:43 brett.cannon set status: open -> closedassignee: brett.cannonresolution: fixedstage: needs patch -> resolved
2012-04-20 19:52:23 python-dev set nosy: + python-devmessages: +
2012-04-18 14:34:16 berker.peksag set nosy: + berker.peksag
2012-04-15 18🔞36 brett.cannon set messages: +
2012-04-15 01:36:34 eric.snow set nosy: + eric.snow
2012-04-15 01:27:46 brett.cannon set keywords: + easy
2012-04-15 01:27:43 brett.cannon set stage: needs patchcomponents: + Testsversions: + Python 3.3
2012-04-15 01:27:25 brett.cannon create

Supported by The Python Software Foundation,
Powered by Roundup

Copyright © 1990-2022, Python Software Foundation
Legal Statements