Issue 14752: Memleak in typeobject add_methods() (original) (raw)

Issue14752

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

This issue has been migrated to GitHub: https://github.com/python/cpython/issues/58957

classification

Title:	Memleak in typeobject add_methods()
Type:	resource usage	Stage:	resolved
Components:	Interpreter Core	Versions:	Python 3.4

process

Status:	closed	Resolution:	fixed
Dependencies:		Superseder:
Assigned To:		Nosy List:	cassou, lemburg, python-dev, tim.peters
Priority:	normal	Keywords:	patch

Created on 2012-05-08 13:19 by cassou, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name	Uploaded	Description	Edit
fix_add_methods_leak.patch	cassou,2012-05-08 13:19	Patch that fixes a memory leak in add_methods() from typeobject.c	review

| Repositories containing patches | | | | | ------------------------------------------------------------------------------------------------------------------------------------------ | | | | | https://DamienCassou@bitbucket.org/DamienCassou/cpython | | | |

Messages (2)
msg160203 - (view)	Author: Damien Cassou (cassou)	Date: 2012-05-08 13:19
In add_methods() function from typeobject.c, it looks like Py_DECREF is not called where it should be. Please find attached a patch that fixes the leak. The patch is also in commit #85a01718b3e3 of my hg repository under the branch fix_add_methods_leak. This bug has been found using Coccinelle (http://coccinelle.lip6.fr/) and a dedicated semantic patch (https://gist.github.com/2634899).
msg160204 - (view)	Author: Roundup Robot (python-dev)	Date: 2012-05-08 13:23
New changeset d937b527b76e by Benjamin Peterson in branch '3.2': fix possible refleak (closes #14752) http://hg.python.org/cpython/rev/d937b527b76e New changeset 5319a4bf72e7 by Benjamin Peterson in branch '2.7': fix possible refleak (closes #14752) http://hg.python.org/cpython/rev/5319a4bf72e7 New changeset 07b04373aef8 by Benjamin Peterson in branch 'default': merge 3.2 (#14752) http://hg.python.org/cpython/rev/07b04373aef8

History
Date	User	Action	Args
2022-04-11 14:57:30	admin	set	github: 58957
2012-05-08 13:23:15	python-dev	set	status: open -> closednosy: + python-devmessages: + resolution: fixedstage: resolved
2012-05-08 13:19:49	cassou	create

Supported by The Python Software Foundation,
Powered by Roundup