| msg50103 - (view) |
Author: Thenault Sylvain (syt) |
Date: 2006-04-24 13:09 |
| Here is a patch for the bug described in https://sourceforge.net/tracker/?func=detail&atid=105470&aid=1448060&group_id=5470 It follows the latest Martin followup as I understand it. I'm not sure if multi-lines field handling should be totally discarded while reading metadata headers (as implemented), or if it should only be discarded for the content-type and plural-forms header. If one think this patch isn't correct, please comment so I can fix it. Notice that if the second solution was intended, lines such as "#-#-#-#-# fr.po #-#-#-#-#\n" inserted by msgcat/msgmerge will have to be treated differently (i.e. multi-lines support but skip lines begining with a #). |
|
|
| msg50104 - (view) |
Author: Martin v. Löwis (loewis) *  |
Date: 2006-07-17 07:45 |
| Logged In: YES user_id=21627 The patch is wrong; it breaks the existing test case WeirdMetadataTest. I think the "just a single line" rule should be restricted to Plural-Forms; not sure whether it should apply to content-type also (but why not). I'll attach another patch that adds a test case. |
|
|
| msg50105 - (view) |
Author: Martin v. Löwis (loewis) * |
Date: 2006-08-25 00:13 |
| Logged In: YES user_id=21627 Couldn't get to it before 2.5; forwarding to 2.4.4/2.5.1 |
|
|
| msg110389 - (view) |
Author: Mark Lawrence (BreamoreBoy) * |
Date: 2010-07-15 21:50 |
| Attached patch is my take on the fix to this, it's a two line change to gettext.py for 2.7. If the change is accepted I'll provide another patch for py3k. Nosy list updated while I'm at it. |
|
|
| msg110396 - (view) |
Author: Mark Lawrence (BreamoreBoy) * |
Date: 2010-07-15 22:53 |
| Sorry, forgot to say that the patched code passed all tests in the patched unit test file. |
|
|
| msg110413 - (view) |
Author: Senthil Kumaran (orsenthil) * |
Date: 2010-07-16 05:45 |
| Minor change request. +class Bug1448060(GettextBaseTest): Can you name the test class something more meaningful like PluralFormsTest or something like that. It is helpful when looking at it later. (Btw, this can be done by the committer during checkin too) |
|
|
| msg110429 - (view) |
Author: Mark Lawrence (BreamoreBoy) * |
Date: 2010-07-16 12:15 |
| Point taken I'll settle for PluralFormsTest unless there's a better idea. Assuming patch acceptance could a committer do this please? |
|
|
| msg116125 - (view) |
Author: Éric Araujo (eric.araujo) * |
Date: 2010-09-11 22:23 |
| Could you follow the guidelines at http://www.python.org/dev/patches/ to create patches? Thanks in advance. I wonder why you call tearDown from setUp. Doesn’t unittest do that for you when there is a failure in setUp? Also, you could use a with statement instead of try/finally. |
|
|
| msg139239 - (view) |
Author: Dirkjan Ochtman (djc) * |
Date: 2011-06-27 07:29 |
| This looks similar to https://bugs.gentoo.org/show_bug.cgi?id=373115. Is it the same thing, or should I file a separate bug for it? (Sorry, I don't intend to hijack this bug, but I don't know much about gettext and the patch here looks somewhat similar to the patch proposed there.) |
|
|
| msg139244 - (view) |
Author: Martin v. Löwis (loewis) * |
Date: 2011-06-27 08:12 |
| It's difficult to tell whether it's the same thing. Is the po file in question available readily for inspection? |
|
|
| msg139246 - (view) |
Author: Dirkjan Ochtman (djc) * |
Date: 2011-06-27 08:31 |
| Looks like this was the problem: http://git.fedorahosted.org/git/?p=virt-manager.git;a=commitdiff;h=cb56316cf3702f03b05e30f406ff3028e45f7bfb. E.g., the empty Plural-Forms header is throwing off the python gettext parser. |
|
|
| msg139326 - (view) |
Author: Martin v. Löwis (loewis) * |
Date: 2011-06-27 21:05 |
| Ok. This is a different issue, then. |
|
|
| msg139348 - (view) |
Author: Dirkjan Ochtman (djc) * |
Date: 2011-06-28 07:38 |
| Okay, I've filed . |
|
|
| msg240633 - (view) |
Author: A.M. Kuchling (akuchling) * |
Date: 2015-04-13 15:55 |
| I think that #17898 is in fact a duplicate of this bug, due to old values of k and v confusing things. Mark's patch looks correct to me, but the patch in #17898 also adds a test. If that patch gets reviewed, I'll apply it to 3.4/3.5, and possibly to 2.7. |
|
|
| msg240895 - (view) |
Author: A.M. Kuchling (akuchling) * |
Date: 2015-04-14 14:39 |
| #17898 has been closed with basically the same fix as Mark's patch, so I'll close this issue. |
|
|