| msg161565 - (view) |
Author: Kristján Valur Jónsson (kristjan.jonsson) *  |
Date: 2012-05-25 11:02 |
| the documentation for generator.throw() does not mention the fact that it has the same semantics for the three arguments as a "raise" expression has. The first two arguments can be: throw(exc_type, None) throw(exc_type, value) throw(exc_type, exc_instance) throw(exc_instance, None) |
|
|
| msg209836 - (view) |
Author: Yury Selivanov (yselivanov) * |
Date: 2014-01-31 22:11 |
| Kristjan, can you write a patch for this? |
|
|
| msg210139 - (view) |
Author: Kristján Valur Jónsson (kristjan.jonsson) * |
Date: 2014-02-03 15:19 |
| Here's one for 2.7. I'm still looking at 3. The funny thing is that the signature of generator.throw reflects 2.x conventions. I'm figuring out if it can be used with the .with_traceback() idiom |
|
|
| msg210146 - (view) |
Author: Kristján Valur Jónsson (kristjan.jonsson) * |
Date: 2014-02-03 15:57 |
| And 3.x |
|
|
| msg210150 - (view) |
Author: Yury Selivanov (yselivanov) * |
Date: 2014-02-03 17:35 |
| I like the patches, except the example in 3x.diff. Please see the review. |
|
|
| msg210188 - (view) |
Author: Kristján Valur Jónsson (kristjan.jonsson) * |
Date: 2014-02-04 09:45 |
| Note that the docstring does not match the doc: PyDoc_STRVAR(throw_doc, "throw(typ[,val[,tb]]) -> raise exception in generator,\n\ return next yielded value or raise StopIteration."); Should I change the docstring too? |
|
|
| msg245559 - (view) |
Author: Martin Panter (martin.panter) * |
Date: 2015-06-20 12:00 |
| See Issue 13213 for some analysis of the behaviour of different combinations of arguments. The docstring should be changed if necessary, but in this case I don’t see what needs changing. The argument names perhaps, just for consistency’s sake? |
|
|
| msg254824 - (view) |
Author: Martin Panter (martin.panter) * |
Date: 2015-11-18 00:00 |
| I can’t really comment on the 2.7 version, because I’m not too familiar with Python 2 exceptions. For Python 3, is there any reason to bless the None, tuple or non-exception cases as the exception “value” argument? IMO these just make things too complicated without any benefit. Changes I would make to the patch: * Only mention that “value” can be omitted, or it can be an instance of the class specified by “type”. Drop mentioning the None option, and the single or tuple constructor argument options. It looks like the tuple option actually gets expanded to multiple constructor arguments?! * Mention that if “value” is passed, its traceback could be lost * Drop the example, unless someone can come up with a concise and realistic example * Unify with definition for coroutines <https://docs.python.org/dev/reference/datamodel.html#coroutine.throw> * Change the doc string(s) to match the argument names, but don’t bother copying the full definition text |
|
|
| msg255913 - (view) |
Author: Martin Panter (martin.panter) * |
Date: 2015-12-05 01:23 |
| Changes in throw-3x.v2.patch: * Split into two signatures * Added parallel coroutine.throw(value) signature * *Value* should be an exception instance; drop mentioning other options * Default value is instantiated from *type* * __traceback__ can be cleared * Dropped the example * Update generator and coroutine doc strings with double signatures |
|
|
| msg256627 - (view) |
Author: Yury Selivanov (yselivanov) * |
Date: 2015-12-17 23:32 |
| Martin, could you please rebase your patch on top of recent cpython default branch, so that a 'review' link appears? |
|
|
| msg256716 - (view) |
Author: Martin Panter (martin.panter) * |
Date: 2015-12-19 01:21 |
| This one is based on the public 3.5 branch, so should work. I corrected a small typo made in the previous patch. |
|
|
| msg327913 - (view) |
Author: Cheryl Sabella (cheryl.sabella) * |
Date: 2018-10-17 22:00 |
| It seems that this patch was close to being merged. Would it be helpful for me to create a PR for it over 3.8? Thanks! |
|
|
| msg414774 - (view) |
Author: Guido van Rossum (gvanrossum) * |
Date: 2022-03-08 21:03 |
| This still hasn't been fixed. I suspect that a new patch should be produced and uploaded as a PR. It looks pretty simple. |
|
|
| msg416436 - (view) |
Author: Andrew Svetlov (asvetlov) * |
Date: 2022-03-31 13:57 |
| New changeset 8be7c2bc5ad5e295f0f855bb31db412eef2c7c92 by Dave Goncalves in branch 'main': bpo-14911: Corrected generator.throw() documentation (GH-32207) https://github.com/python/cpython/commit/8be7c2bc5ad5e295f0f855bb31db412eef2c7c92 |
|
|
| msg416437 - (view) |
Author: miss-islington (miss-islington) |
Date: 2022-03-31 14:23 |
| New changeset 625f6704c0d783360574bbab2f78b0b9bbed5891 by Miss Islington (bot) in branch '3.10': bpo-14911: Corrected generator.throw() documentation (GH-32207) https://github.com/python/cpython/commit/625f6704c0d783360574bbab2f78b0b9bbed5891 |
|
|
| msg416438 - (view) |
Author: miss-islington (miss-islington) |
Date: 2022-03-31 14:24 |
| New changeset 98d57737de73342d33d1b90dc0285f586465d22b by Miss Islington (bot) in branch '3.9': bpo-14911: Corrected generator.throw() documentation (GH-32207) https://github.com/python/cpython/commit/98d57737de73342d33d1b90dc0285f586465d22b |
|
|