original ) (raw ) Issue15394
Created on 2012-07-19 13:24 by jll , last changed 2022-04-11 14:57 by admin . This issue is now closed .
Files
File name
Uploaded
Description
Edit
moduleobject.patch jll,2012-07-19 13:24
patch on objects/moduleobject.c
review
Messages (4)
msg165838 - (view) Author: Julia Lawall (jll) *
Date: 2012-07-19 13:24
In objects/moduleobject.c, in the function PyModule_Create2, it appears that m should be decrefed on all of the failure paths between its allocation and the return from the function.
msg165843 - (view) Author: Meador Inge (meador.inge) *
Date: 2012-07-19 15:02
This looks OK to me (I don't see a way to write a test case to cover the leak). I will commit later today unless I hear some objections.
msg165853 - (view) Author: Roundup Robot (python-dev)
Date: 2012-07-19 18:52
New changeset 7140d97d36fd by Meador Inge in branch '3.2': Issue #15394 : Fix ref leaks in PyModule_Create. http://hg.python.org/cpython/rev/7140d97d36fd New changeset 571777bf5527 by Meador Inge in branch 'default': Issue #15394 : Fix ref leaks in PyModule_Create. http://hg.python.org/cpython/rev/571777bf5527
msg165854 - (view) Author: Meador Inge (meador.inge) *
Date: 2012-07-19 18:55
Thanks for the patch Julia!
History
Date
User
Action
Args
2022-04-11 14:57:33
admin
set
github: 59599
2012-07-19 19:07:44
jcea
set
nosy: + jcea
2012-07-19 18:55:28
meador.inge
set
status: open -> closedresolution: fixedmessages: + stage: commit review -> resolved
2012-07-19 18:52:41
python-dev
set
nosy: + python-dev messages: +
2012-07-19 15:02:35
meador.inge
set
versions: + Python 3.3nosy: + meador.inge messages: + assignee: meador.inge stage: commit review
2012-07-19 13:24:56
jll
create
