Issue 15444: Incorrectly written contributor's names (original) (raw)

process

Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: docs@python Nosy List: chris.jerdonek, docs@python, ezio.melotti, ghaering, jcea, lars.gustaebel, lemburg, loewis, neologix, pitrou, python-dev, serhiy.storchaka, terry.reedy, zseil
Priority: normal Keywords: needs review, patch

Created on 2012-07-24 20:25 by serhiy.storchaka, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
doc-nonascii-names-2.patch serhiy.storchaka,2012-07-25 07:45 review
Messages (20)
msg166330 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2012-07-24 20:25
Some contributor's names written incorrectly (in ASCII) in documentation: Jesús Cea Avión as Jesús Cea Avion Lars Gustäbel as Lars Gustaebel Gerhard Häring as Gerhard Haering Marc-André Lemburg as Marc-Andre Lemburg Martin von Löwis as Martin von Loewis Charles-François Natali as Charles-Francois Natali Žiga Seilnach as Ziga Seilnacht The proposed patch restores natural spelling (based on Doc/ACKS and Misc/ACKS). I'm not sure about how to write right: Žiga Seilnach or Seilnacht?
msg166342 - (view) Author: Chris Jerdonek (chris.jerdonek) * (Python committer) Date: 2012-07-24 23:40
It seems to be the latter: Žiga Seilnacht http://mail.python.org/pipermail/python-dev/2007-March/071786.html
msg166356 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2012-07-25 06:18
> It seems to be the latter: Žiga Seilnacht Then Misc/ACKS should be corrected too.
msg166357 - (view) Author: Chris Jerdonek (chris.jerdonek) * (Python committer) Date: 2012-07-25 06:25
Is there a reason not to correct that spelling in this issue? Otherwise, we could create a new issue.
msg166359 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2012-07-25 07:21
There was a long-standing opposition by Guido to use UTF-8 in that file, and also complaints about legibility. Not sure what the current status is. It doesn't matter much to me, even though the spelling of my name is affected.
msg166360 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2012-07-25 07:45
Well, here is updated patch. Also fixed names of Walter Dörwald (was Walter D�rwald) and Martin von Löwis in Misc/HISTORY. All changed files (documentation, ACK-files, Misc/HISTORY) already in UTF-8 and contains non-ASCII names. Löwis written as Loewis in some other places: Lib/idlelib/NEWS.txt, Tools/README, source comments. Same for Marc-Andre (without é) Lemburg. I do not think, that it matter in comments, but not sure about NEWS- and README-files.
msg166367 - (view) Author: Marc-Andre Lemburg (lemburg) * (Python committer) Date: 2012-07-25 08:44
Thank you for taking the initiative. Regarding use of UTF-8 for text files: I think we ought to acknowledge that UTF-8 has become the defacto standard for non-ASCII text files by now and with Python 3 being all Unicode, it feels silly not make use of it in Python source files. Regarding my name: I have no issue with the apostrophe missing on the e. I've long given up using it in source code or emails :-)
msg166407 - (view) Author: Chris Jerdonek (chris.jerdonek) * (Python committer) Date: 2012-07-25 15:59
To be clear on this issue's scope, I would state in a single comment a white list of which directories or individual files are being corrected (or if necessary, the rules to determine such a list, e.g. any file whose name root is "NEWS", etc). I would also recommend being systematic about this by creating a script to search the above files, along with a configuration section containing the list of replacements: e.g. correct spelling -> list of misspellings for that name. And upload the script to this issue. That way people can see what misspellings have already been accounted for, more could be added easily, and it could be used again if necessary. Because this may grow in scope (e.g. into source files) and because it affects people's names, it may be worth raising on python-dev. At the least, people would have the chance to contribute known misspellings.
msg166408 - (view) Author: Ezio Melotti (ezio.melotti) * (Python committer) Date: 2012-07-25 16:10
Make sure that it's still possible to generate the pdf of the docs (with `make latex` and then `make all-pdf` in build/latex/). Latin1 should be fine, but IIRC non-latin1 will break (sorry Žiga).
msg166415 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2012-07-25 16:54
Indeed, PDF rendering is important. OTOH, Latex T1 does support Ž. Untested, \v{Z} should generate that character. If this doesn't work, the build process needs to be fixed.
msg166419 - (view) Author: Ezio Melotti (ezio.melotti) * (Python committer) Date: 2012-07-25 18:42
> Indeed, PDF rendering is important. OTOH, Latex T1 does support Ž. I tried to put a Ž directly in an rst source and indeed the pdf has been created correctly.
msg166421 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2012-07-25 19:38
All names interpreted correctly except cyrillic (Alexander “Саша” Belopolsky and Марк Коренберг). I think it's just because of lack of some non-installed package (of course, Latex supports cyrillic).
msg166608 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2012-07-27 22:03
I basically agree with Marc-André. Indeed, I think Acks, at least, should contain names in native spelling plus, if that is not Latin-based, a romanization. Three reasons: 1. I want English-speaking Python programmers to feel welcome to contribute and be acknowledged with what is visibly their native name. 2. I want people to be able to looks at the contributors list and see that Python is an international project. 3. Transliterations are ofter lossy, and in both directions. Romanizations do not necessarily tell contributors' compatriots how to address them in their mutual native language. If stdlib .py files are still restricted to romanizations, those could at least be looked up in Acks. But Python does come with an utf-8 unicode editor, Idle, that handles at least the BMP just fine (because tcl/tk does).
msg166619 - (view) Author: Chris Jerdonek (chris.jerdonek) * (Python committer) Date: 2012-07-27 23:36
The idea also to include a romanization is a good one. While working on issue 15437, it occurred to me that storing the names in a structured form might come in handy. This would let us do things like list the username(s) associated with each contributor alongside their name (and access this information programmatically). And perhaps also include information like the following: http://www.python.org/dev/committers
msg167845 - (view) Author: Chris Jerdonek (chris.jerdonek) * (Python committer) Date: 2012-08-09 22:07
> While working on issue 15437, it occurred to me that storing the names in a structured form might come in handy. In a separate discussion, Ezio pointed out a case where we are already scraping data about members from doc files: http://hg.python.org/tracker/python-dev/file/69984a770ab5/extensions/jnosy.py So there is another case where we would benefit from storing names with associated attributes in a centralized, structured way. Sorry if this is a departure from the topic of this issue. I may create a separate issue for this or raise the idea in another forum.
msg167901 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2012-08-10 17:55
What about patch review?
msg167954 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2012-08-11 13:38
The patch looks ok to me so, unless someone is opposed to using utf-8 in the doc files, I think it can be committed in 3.x.
msg167962 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2012-08-11 14:48
Non-ascii characters already used in a lot (43-50) of doc files. LC_ALL=C find Doc/ -type f -name '*.rst' -exec egrep --color "$(printf '[\x80-\xFF]+')" '{}' + All touched files already contains non-ascii characters (and Misc/HISTORY contains invalid UTF-8 sequence).
msg167964 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2012-08-11 14:57
New changeset 3654c711019a by Antoine Pitrou in branch '3.2': Issue #15444: Use proper spelling for non-ASCII contributor names. http://hg.python.org/cpython/rev/3654c711019a New changeset 867de88b69f0 by Antoine Pitrou in branch 'default': Issue #15444: Use proper spelling for non-ASCII contributor names. http://hg.python.org/cpython/rev/867de88b69f0
msg167965 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2012-08-11 14:58
Ok, then I've committed the patch. Closing the issue now, thank you.
History
Date User Action Args
2022-04-11 14:57:33 admin set github: 59649
2012-08-11 14:59:00 pitrou set status: open -> closedversions: - Python 2.7messages: + resolution: fixedstage: patch review -> resolved
2012-08-11 14:57:19 python-dev set nosy: + python-devmessages: +
2012-08-11 14:48:22 serhiy.storchaka set messages: +
2012-08-11 13:38:29 pitrou set nosy: + pitroumessages: +
2012-08-10 17:56:11 serhiy.storchaka set files: - doc-nonascii-names.patch
2012-08-10 17:55:02 serhiy.storchaka set keywords: + needs reviewmessages: +
2012-08-09 22:07:09 chris.jerdonek set messages: +
2012-07-27 23:36:55 chris.jerdonek set messages: +
2012-07-27 22:03:26 terry.reedy set nosy: + terry.reedymessages: +
2012-07-25 19:38:45 serhiy.storchaka set messages: +
2012-07-25 18:42:03 ezio.melotti set messages: +
2012-07-25 16:54:10 loewis set messages: +
2012-07-25 16:10:52 ezio.melotti set nosy: + ezio.melottimessages: +
2012-07-25 15:59:28 chris.jerdonek set messages: +
2012-07-25 08:44:42 lemburg set messages: +
2012-07-25 07:45:24 serhiy.storchaka set files: + doc-nonascii-names-2.patchmessages: + title: Incorrectly writen contributor's names -> Incorrectly written contributor's names
2012-07-25 07:21:54 loewis set messages: +
2012-07-25 06:25:14 chris.jerdonek set messages: +
2012-07-25 06🔞01 serhiy.storchaka set messages: +
2012-07-24 23:40:22 chris.jerdonek set nosy: + chris.jerdonekmessages: +
2012-07-24 20:27:53 pitrou set stage: patch reviewversions: + Python 2.7, Python 3.2, Python 3.3
2012-07-24 20:25:10 serhiy.storchaka create