Issue 1545837: array.array borks on deepcopy (original) (raw)

Created on 2006-08-24 09:49 by wilx, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (9)
msg29667 - (view) Author: Václav Haisman (wilx) Date: 2006-08-24 09:49
Hi, I think there is a bug arraymodule.c this line: {"__deepcopy__",(PyCFunction)array_copy, METH_NOARGS, copy_doc}, should probably have METH_O instead of METH_NOARGS there, since according to docs and the prototype of the array_copy() function there is one parameter.
msg29668 - (view) Author: Thomas Wouters (twouters) * (Python committer) Date: 2006-08-24 18:50
Logged In: YES user_id=34209 Thanks! Fixed in the trunk (which is 2.6-to-be) revision 51565, and it will also be fixed for Python 2.4.4 and 2.5.1. It's unfortunately just a bit too late for 2.5.0.
msg29669 - (view) Author: Raymond Hettinger (rhettinger) * (Python committer) Date: 2006-08-28 13:32
Logged In: YES user_id=80475 Should this be fixed in the release candidate?
msg29670 - (view) Author: Thomas Wouters (twouters) * (Python committer) Date: 2006-08-29 07:35
Logged In: YES user_id=34209 Not unless you want another release candidate. copy.deepcopy has never worked on array instances, so it's not a release-preventing bug (but each bugfix may *add* a release-preventing bug by accident :)
msg29671 - (view) Author: Neal Norwitz (nnorwitz) * (Python committer) Date: 2006-12-28 07:59
Thomas, was there any reason this wasn't checked in to 2.5? I'm guessing it was just forgotten. I don't see any mention in Misc/NEWS either.
msg29672 - (view) Author: Thomas Wouters (twouters) * (Python committer) Date: 2006-12-28 09:11
The 2.5 branch at the time was still pre-2.5.0, and we didn't want to make this change between release candidate and release. It's safe to be checked into release25-maint now. I'll do it sometime tonight.
msg29673 - (view) Author: Thomas Wouters (twouters) * (Python committer) Date: 2006-12-29 15:05
Backported.
msg29674 - (view) Author: Neal Norwitz (nnorwitz) * (Python committer) Date: 2007-01-06 21:19
Thomas, was there any reason this wasn't checked in to 2.5? I'm guessing it was just forgotten. I don't see any mention in Misc/NEWS either.
msg29675 - (view) Author: Neal Norwitz (nnorwitz) * (Python committer) Date: 2007-01-06 21:21
Stupid SF.
History
Date User Action Args
2022-04-11 14:56:19 admin set github: 43889
2008-01-16 09:55:48 mephinet set nosy: + mephinet
2006-08-24 09:49:37 wilx create