Issue 15656: "Extending Python with C" page needs update for 3.x (original) (raw)

Issue15656

Created on 2012-08-14 18:57 by sandro.tosi, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Messages (5)
msg168223 - (view)	Author: Sandro Tosi (sandro.tosi) *	Date: 2012-08-14 18:57
Hello, this has been reported at http://mail.python.org/pipermail/docs/2012-July/009223.html but since I have no experience to judge if it's correct or not, i'll just report it: >>> I've recenty started to try using C code in python using the wonderful python API, although i have to say the learning curve was non neglectable :P I've spotted what I believe to be a small mistake in the documentation from this page: http://docs.python.org/release/3.2/extending/extending.html In paragraph 1.8 (http://docs.python.org/release/3.2/extending/extending.html#keyword-parameters-for-extension-functions), the code example given contains an error, which is actually obsolete code from python 2.7: void initkeywdarg(void) { /* Create the module and add the functions */ Py_InitModule("keywdarg", keywdarg_methods); } This doesn't work in Python3.2. It's supposed to be static struct PyModuleDef keywdargmodule = { PyModuleDef_HEAD_INIT, "keywdarg", /* name of module */ keywdarg_doc, /* module documentation, may be NULL */ -1, /* size of per-interpreter state of the module, or -1 if the module keeps state in global variables. */ keywdarg_methods }; PyMODINIT_FUNC PyInit_keywdarg(void) { return PyModule_Create(&keywdargmodule); } As explained above (and confirmed by experience). <<<
msg168283 - (view)	Author: Roundup Robot (python-dev)	Date: 2012-08-15 11:52
New changeset 599376deeeac by Eli Bendersky in branch '3.2': Issue #15656: fixing code sample in extending doc http://hg.python.org/cpython/rev/599376deeeac
msg168284 - (view)	Author: Eli Bendersky (eli.bendersky) *	Date: 2012-08-15 11:53
Fixed, thanks for the report.
msg168319 - (view)	Author: Jesús Cea Avión (jcea) *	Date: 2012-08-15 19:35
Should this be applied to "default" (3.3) too?
msg168321 - (view)	Author: Sandro Tosi (sandro.tosi) *	Date: 2012-08-15 19:40
It's fixed in default too: http://hg.python.org/cpython/rev/f46b4b7b817c It was not shown because the commit message misses the issue reference.