Issue 16102: uuid._netbios_getnode() is outdated (original) (raw)

This issue has been migrated to GitHub: https://github.com/python/cpython/issues/60306

classification

Title: uuid._netbios_getnode() is outdated
Type: behavior Stage: resolved
Components: Library (Lib), Windows Versions: Python 3.2, Python 3.3, Python 3.4

process

Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: serhiy.storchaka Nosy List: akuchling, brian.curtin, pitrou, python-dev, serhiy.storchaka, tim.golden
Priority: normal Keywords: needs review, patch

Created on 2012-10-01 17:33 by serhiy.storchaka, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
uuid_netbios_getnode.patch serhiy.storchaka,2012-10-22 11:52 review
Messages (7)
msg171736 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2012-10-01 17:33
Function uuid._netbios_getnode() in Lib/uuid.py is not properly ported from Python 2. At least it uses indexing on map result. Perhaps there are other errors. The function obviously not been tested for years.
msg173506 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2012-10-22 11:52
As I see in pywin32 sources status.adapter_address is bytes in Python 3. Here is a trivial patch.
msg190265 - (view) Author: A.M. Kuchling (akuchling) * (Python committer) Date: 2013-05-29 02:04
This patch seems obviously correct to me, so it should be applied. It looks like there's already a test in test_uuid.py that exercises _netbios_getnode() if the netbios module is importable, so there's no test to add, though maybe we need a buildbot that has the module available.
msg190283 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2013-05-29 10:03
If noone has reported the issue in years (Google doesn't seem to report any occurrence), perhaps it means the code is simply not used anymore? In which case it should probably be removed.
msg190297 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2013-05-29 12:25
Any exceptions were silently dropped. And tests silently skipped ().
msg190869 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2013-06-09 18:10
New changeset 27f55ff12f41 by Serhiy Storchaka in branch '3.3': Issue #16102: Make uuid._netbios_getnode() work again on Python 3. http://hg.python.org/cpython/rev/27f55ff12f41 New changeset 4a0017722910 by Serhiy Storchaka in branch 'default': Issue #16102: Make uuid._netbios_getnode() work again on Python 3. http://hg.python.org/cpython/rev/4a0017722910
msg227961 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2014-09-30 17:34
New changeset f9cd915410d2 by Georg Brandl in branch '3.2': Issue #19855: uuid.getnode() on Unix now looks on the PATH for the https://hg.python.org/cpython/rev/f9cd915410d2
History
Date User Action Args
2022-04-11 14:57:36 admin set github: 60306
2014-09-30 17:34:51 python-dev set messages: +
2013-06-09 18:23:12 serhiy.storchaka set status: open -> closedresolution: fixedstage: commit review -> resolved
2013-06-09 18:10:47 python-dev set nosy: + python-devmessages: +
2013-05-29 12:25:12 serhiy.storchaka set messages: +
2013-05-29 11:13:41 serhiy.storchaka set assignee: serhiy.storchaka
2013-05-29 10:03:31 pitrou set nosy: + pitroumessages: +
2013-05-29 02:04:36 akuchling set nosy: + akuchlingmessages: + stage: patch review -> commit review
2013-04-05 23:42:19 pitrou set nosy: + tim.golden, brian.curtin
2012-10-24 08:58:56 serhiy.storchaka set keywords: + needs reviewstage: patch review
2012-10-22 11:52:34 serhiy.storchaka set files: + uuid_netbios_getnode.patchkeywords: + patchmessages: +
2012-10-01 17:33:29 serhiy.storchaka create