original ) (raw )process
Status :closed
Resolution :rejected
Dependencies :Superseder :
Assigned To :ezio.melotti
Nosy List :Ramchandra Apte, brett.cannon, chris.jerdonek, christian.heimes, eric.araujo, ezio.melotti, georg.brandl, jcea, maker, michael.foord, pitrou
Priority :normal
Keywords :patch
Created on 2012-10-01 23:36 by ezio.melotti , last changed 2022-04-11 14:57 by admin . This issue is now closed .
Messages (10)
msg171762 - (view) Author: Ezio Melotti (ezio.melotti) *
Date: 2012-10-01 23:36
The attached patch adds tests for antigravity.
msg171775 - (view) Author: Georg Brandl (georg.brandl) *
Date: 2012-10-02 06:05
Are you serious?
msg171777 - (view) Author: Christian Heimes (christian.heimes) *
Date: 2012-10-02 08:58
Ezio is as serious as the antigravity module. *g*
msg171797 - (view) Author: Brett Cannon (brett.cannon) *
Date: 2012-10-02 13:10
It's actually a nice example of using unittest.mock. =)
msg171802 - (view) Author: Michael Foord (michael.foord) *
Date: 2012-10-02 13:31
What happens if test_geohash runs first? It looks like test_antigravity will only pass if it is run first. You could remove the order dependence by ensuring antigravity is not in sys.modules. sys.modules.pop('antigravity', None)
msg171805 - (view) Author: Chris Jerdonek (chris.jerdonek) *
Date: 2012-10-02 13:58
Oh, this explains it. I was wondering why my browser was opening xkcd whenever I tried running doctest against all modules in the library.
msg171823 - (view) Author: Antoine Pitrou (pitrou) *
Date: 2012-10-02 18:40
I'm not sure why we would test undocumented jokes... Do other Python implementations have to provide them too?
msg172809 - (view) Author: Ramchandra Apte (Ramchandra Apte) *
Date: 2012-10-13 15:04
@Antoine Aw.. no funny bone in you..
msg172915 - (view) Author: Éric Araujo (eric.araujo) *
Date: 2012-10-14 20:29
Agreed with Antoine.
msg172956 - (view) Author: Ezio Melotti (ezio.melotti) *
Date: 2012-10-15 10:40
The test could be made CPython-specific, but if you think it's not necessary I'll just close the issue. The main reason I wrote this was to experiment a bit with unittest.mock :)
History
Date
User
Action
Args
2022-04-11 14:57:36
admin
set
github: 60310
2012-10-15 10:40:08
ezio.melotti
set
status: open -> closedresolution: rejectedmessages: + stage: patch review -> resolved
2012-10-14 20:29:18
eric.araujo
set
messages: +
2012-10-13 15:04:48
Ramchandra Apte
set
nosy: + Ramchandra Apte messages: +
2012-10-06 16:52:38
eric.araujo
set
nosy: + eric.araujo
2012-10-03 02:19:42
jcea
set
nosy: + jcea
2012-10-02 21:38:11
maker
set
nosy: + maker
2012-10-02 18:40:42
pitrou
set
nosy: + pitrou messages: +
2012-10-02 13:58:07
chris.jerdonek
set
nosy: + chris.jerdonek messages: +
2012-10-02 13:31:36
michael.foord
set
messages: +
2012-10-02 13:10:08
brett.cannon
set
nosy: + brett.cannon messages: +
2012-10-02 08:58:59
christian.heimes
set
nosy: + christian.heimes messages: +
2012-10-02 06:05:11
georg.brandl
set
nosy: + georg.brandl messages: +
2012-10-01 23:36:41
ezio.melotti
create
