Issue 16264: test_logging failure on Windows 7 buildbot (original) (raw)

This issue has been migrated to GitHub: https://github.com/python/cpython/issues/60468

classification

process

Created on 2012-10-17 11:00 by pitrou, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Messages (6)
msg173157 - (view)	Author: Antoine Pitrou (pitrou) *	Date: 2012-10-17 11:00
Changeset d3c7ebdc71bb produced the following test failure on one of the stable buildbots: ====================================================================== FAIL: test_noserver (test.test_logging.SocketHandlerTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\test_logging.py", line 1453, in test_noserver self.assertTrue(self.sock_hdlr.retryTime > now) AssertionError: False is not true See http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.x
msg173158 - (view)	Author: Roundup Robot (python-dev)	Date: 2012-10-17 11:24
New changeset 240fa6e93925 by Giampaolo Rodola' in branch 'default': test_logging.py: where needed use unittest's assertGreater, assertLesser, assertIs rather than assertTrue (also in order to debug issue 16264) http://hg.python.org/cpython/rev/240fa6e93925
msg173159 - (view)	Author: Giampaolo Rodola' (giampaolo.rodola) *	Date: 2012-10-17 11:26
Committed http://hg.python.org/cpython/rev/240fa6e93925 in order to have a clearer look on what's going on. Will get back on this later today, after the next bb failure.
msg173454 - (view)	Author: Roundup Robot (python-dev)	Date: 2012-10-21 15:21
New changeset 0fb2267897ba by Antoine Pitrou in branch 'default': Try to fix issue #16264 (test_logging failure on some buildbots). http://hg.python.org/cpython/rev/0fb2267897ba
msg173456 - (view)	Author: Antoine Pitrou (pitrou) *	Date: 2012-10-21 15:28
Looks ok now. It's a timing glitch because both SocketHandler's built-in timeout and its default retry delay are one second, so when connect times out once the next retry time is a bit behind time.time(). (note: SocketHandler's implementation looks grotesque. Enough said).
msg173859 - (view)	Author: Vinay Sajip (vinay.sajip) *	Date: 2012-10-26 16:19
> (note: SocketHandler's implementation looks grotesque. Enough said). Care to be a little more constructive in your criticism? I'm quite open to improving it, if you have any suggestions for doing so. It's a very basic exponential back-off approach - the only intent was not to keep trying to frequently connect to a server which might be offline or unreachable.