Issue 16601: Restarting iteration over tarfile continues from where it left off. (original) (raw)

Created on 2012-12-03 20:01 by mbirtwell, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
fix-tarfile-restart-iteration.patch mbirtwell,2012-12-03 20:01 Patch review
fix-tarfile-restart-iteration2.patch mbirtwell,2012-12-03 20:19 review
test-tarfile-restart-iteration.patch mbirtwell,2012-12-03 23:00 review
Messages (10)
msg176863 - (view) Author: Michael Birtwell (mbirtwell) * Date: 2012-12-03 20:01
If you partially iterate over a tarfile then try and restart iteration of that tarfile it will continue from where it left off rather than restarting from the beginning. I've only tried this with the tarfile implementation in python 2.7 but the 3.x code looks the same in this respect. I've included a patch with my approach to fixing this.
msg176865 - (view) Author: Michael Birtwell (mbirtwell) * Date: 2012-12-03 20:19
Embarrassingly as soon as I uploaded that patch I found a problem with it. I hadn't taken in to account the special case for the first member. Here's a replacement patch
msg176866 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2012-12-03 20:56
Thanks for the patch. Could you either include a test or post code that demonstrates the problem, please?
msg176868 - (view) Author: Michael Birtwell (mbirtwell) * Date: 2012-12-03 23:00
Here's a patch on the tarfile's unittest module.
msg177074 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2012-12-07 09:07
Related issue: .
msg179831 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2013-01-12 21:16
Michael Birtwell, can you please submit a contributor form? http://python.org/psf/contrib/contrib-form/ http://python.org/psf/contrib/
msg181141 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2013-02-02 07:38
Michael, what's the status of your contributor form?
msg188763 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2013-05-09 11:39
New changeset 9b86fb6f5bc9 by Serhiy Storchaka in branch '2.7': Issue #16601: Restarting iteration over tarfile no more continues from where http://hg.python.org/cpython/rev/9b86fb6f5bc9 New changeset 9ed127d8ad61 by Serhiy Storchaka in branch '3.3': Issue #16601: Restarting iteration over tarfile no more continues from where http://hg.python.org/cpython/rev/9ed127d8ad61 New changeset 1c6a1427353b by Serhiy Storchaka in branch 'default': Issue #16601: Restarting iteration over tarfile no more continues from where http://hg.python.org/cpython/rev/1c6a1427353b
msg188764 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2013-05-09 12:01
Thank you for contribution. I have committed simpler test.
msg188765 - (view) Author: Michael Birtwell (mbirtwell) * Date: 2013-05-09 12:13
Sorry about the delay in the contributor form. Things got in the way then I completely forgot about it. It's done now.
History
Date User Action Args
2022-04-11 14:57:39 admin set github: 60805
2013-05-09 12:14:35 serhiy.storchaka link issue16631 superseder
2013-05-09 12:13:09 mbirtwell set messages: +
2013-05-09 12:01:14 serhiy.storchaka set status: open -> closedversions: - Python 3.2messages: + resolution: fixedstage: patch review -> resolved
2013-05-09 11:39:31 python-dev set nosy: + python-devmessages: +
2013-02-02 07:38:40 serhiy.storchaka set messages: +
2013-01-12 21:16:48 serhiy.storchaka set messages: +
2012-12-29 21:57:46 serhiy.storchaka set assignee: serhiy.storchaka
2012-12-15 18:01:55 asvetlov set nosy: + asvetlov
2012-12-14 08:35:58 Arfrever set nosy: + Arfrever
2012-12-07 09:08:49 serhiy.storchaka set stage: patch review
2012-12-07 09:08:32 serhiy.storchaka set nosy: + lars.gustaebelversions: + Python 3.2, Python 3.3, Python 3.4
2012-12-07 09:07:45 serhiy.storchaka set nosy: + serhiy.storchakamessages: +
2012-12-05 20:38:26 jcea set nosy: + jcea
2012-12-03 23:00:41 mbirtwell set files: + test-tarfile-restart-iteration.patchmessages: +
2012-12-03 20:56:31 r.david.murray set nosy: + r.david.murraymessages: +
2012-12-03 20:19:33 mbirtwell set files: + fix-tarfile-restart-iteration2.patchtype: behaviormessages: +
2012-12-03 20:01:12 mbirtwell create