Issue 16792: Mark small ints test as CPython-only (original) (raw)
This issue has been migrated to GitHub: https://github.com/python/cpython/issues/60996
classification
Title: | Mark small ints test as CPython-only | ||
---|---|---|---|
Type: | enhancement | Stage: | resolved |
Components: | Tests | Versions: | Python 3.2, Python 3.3, Python 3.4, Python 2.7 |
process
Status: | closed | Resolution: | fixed |
---|---|---|---|
Dependencies: | Superseder: | ||
Assigned To: | serhiy.storchaka | Nosy List: | chris.jerdonek, mark.dickinson, python-dev, serhiy.storchaka |
Priority: | normal | Keywords: | patch |
Created on 2012-12-27 15:34 by serhiy.storchaka, last changed 2022-04-11 14:57 by admin. This issue is now closed.
Files | |||
---|---|---|---|
File name | Uploaded | Description | Edit |
int_test_small_ints-3.3.patch | serhiy.storchaka,2012-12-27 15:34 | review | |
int_test_small_ints-3.2.patch | serhiy.storchaka,2012-12-27 15:34 | review | |
int_test_small_ints-2.7.patch | serhiy.storchaka,2012-12-27 15:35 | review |
Messages (6) | ||
---|---|---|
msg178300 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * ![]() |
Date: 2012-12-27 15:34 |
Small ints test should be extracted to a separate method and marked as CPython only. In additional it backported to 2.7. | ||
msg178320 - (view) | Author: Mark Dickinson (mark.dickinson) * ![]() |
Date: 2012-12-27 20:26 |
LGTM. | ||
msg178342 - (view) | Author: Roundup Robot (python-dev) ![]() |
Date: 2012-12-27 22:22 |
New changeset 8f82e9992ad9 by Serhiy Storchaka in branch '2.7': Issue #16792: Mark small ints test as CPython-only. http://hg.python.org/cpython/rev/8f82e9992ad9 New changeset 31955234b624 by Serhiy Storchaka in branch '3.2': Issue #16792: Mark small ints test as CPython-only. http://hg.python.org/cpython/rev/31955234b624 New changeset dee82e66726d by Serhiy Storchaka in branch '3.3': Issue #16792: Mark small ints test as CPython-only. http://hg.python.org/cpython/rev/dee82e66726d New changeset 9177d8e6e317 by Serhiy Storchaka in branch 'default': Issue #16792: Mark small ints test as CPython-only. http://hg.python.org/cpython/rev/9177d8e6e317 | ||
msg178343 - (view) | Author: Chris Jerdonek (chris.jerdonek) * ![]() |
Date: 2012-12-27 22:32 |
You can use assertIs() in 2.7 as well, no? + @test_support.cpython_only + def test_small_ints(self): + self.assertTrue(int('10') is 10) | ||
msg178344 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * ![]() |
Date: 2012-12-27 22:40 |
Indeed. | ||
msg178346 - (view) | Author: Roundup Robot (python-dev) ![]() |
Date: 2012-12-27 22:47 |
New changeset 327896bf3152 by Serhiy Storchaka in branch '2.7': Issue #16792: Use assertIs() to test identity. http://hg.python.org/cpython/rev/327896bf3152 |
History | |||
---|---|---|---|
Date | User | Action | Args |
2022-04-11 14:57:39 | admin | set | github: 60996 |
2012-12-27 22:57:38 | serhiy.storchaka | set | status: open -> closedresolution: fixedstage: patch review -> resolved |
2012-12-27 22:47:03 | python-dev | set | messages: + |
2012-12-27 22:40:52 | serhiy.storchaka | set | messages: + |
2012-12-27 22:32:05 | chris.jerdonek | set | messages: + |
2012-12-27 22:22:47 | python-dev | set | nosy: + python-devmessages: + |
2012-12-27 20:58:49 | chris.jerdonek | set | nosy: + chris.jerdonek |
2012-12-27 20:26:02 | mark.dickinson | set | nosy: + mark.dickinsonmessages: + |
2012-12-27 15:37:33 | serhiy.storchaka | link | issue16784 dependencies |
2012-12-27 15:35:02 | serhiy.storchaka | set | files: + int_test_small_ints-2.7.patch |
2012-12-27 15:34:41 | serhiy.storchaka | set | files: + int_test_small_ints-3.2.patch |
2012-12-27 15:34:19 | serhiy.storchaka | create |