| msg58988 - (view) |
Author: toxik (ludvig.ericson) |
Date: 2007-12-25 03:56 |
| It's actually py251. 113 else: 114 f.close() 115 self.copy_file(script, outfile) Earlier, f is set to None if file is not found, and we are in dry-run mode. Simple solution: 113 elif f: 114 f.close() 115 self.copy_file(script, outfile) |
|
|
| msg59084 - (view) |
Author: Guido van Rossum (gvanrossum) *  |
Date: 2008-01-02 03:45 |
| Actually, only the f.close() call should be conditionalized. Does this patch fix the issue for you? |
|
|
| msg59088 - (view) |
Author: toxik (ludvig.ericson) |
Date: 2008-01-02 04:22 |
| It doesn't die now, but AFAICT, it doesn't even try to copy the script now. (With your patch.) I might also add that this is for package_data. |
|
|
| msg59097 - (view) |
Author: Guido van Rossum (gvanrossum) * |
Date: 2008-01-02 17:44 |
| I'm not a big distutils expert myself, I can't quite interpret your feedback. In dry-run mode, it shouldn't try to copy the script, correct? |
|
|
| msg59099 - (view) |
Author: toxik (ludvig.ericson) |
Date: 2008-01-02 17:45 |
| It shouldn't try to copy the script anywhere, it should just tell me what it was going to do, by means of console. |
|
|
| msg59100 - (view) |
Author: Guido van Rossum (gvanrossum) * |
Date: 2008-01-02 18:28 |
| So that's correct behavior right? (I looked at the code for copy_file() in cmd.py and it passes the dry_run parameter to the file utility function that does the actual copying. |
|
|
| msg59101 - (view) |
Author: toxik (ludvig.ericson) |
Date: 2008-01-02 18:32 |
| Mmh, well, as far as I could tell when I tested your patch, it didn't say it's going to copy the file, but it didn't say it isn't going to either. As far as this ticket is concerned however, I'd say the behavior is now fixed. |
|
|
| msg59103 - (view) |
Author: Guido van Rossum (gvanrossum) * |
Date: 2008-01-02 19:01 |
| Committed revision 59668. (2.5 branch) Committed revision 59669. (2.6 trunk) |
|
|