Issue 16965: 2to3 should rewrite execfile() to open in 'rb' mode (original) (raw)

Issue16965

Created on 2013-01-14 18:24 by barry, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Messages (7)
msg179964 - (view)	Author: Barry A. Warsaw (barry) *	Date: 2013-01-14 18:24
In this distribute bug I describe a problem when pip installing mimeparse, which has a setup.py with a BOM. distribute uses execfile() which gets fixed in Python 3 to use a combination of compile(open()) as the fixer. https://bitbucket.org/tarek/distribute/issue/349/dont-rely-on-2to3-to-properly-rewrite I think the problem is that the fixer opens the file in text mode, which leaves the BOM as a bogus first character, causing the SyntaxError. Instead, if the fixer opened the file in binary mode, then the BOM would be handled correctly by compile().
msg223226 - (view)	Author: Mark Lawrence (BreamoreBoy) *	Date: 2014-07-16 15:52
Can we have a response to this please.
msg327567 - (view)	Author: Serhiy Storchaka (serhiy.storchaka) *	Date: 2018-10-12 07:18
`exec(compile(open("fn", "rb").read(), "fn", 'exec'))` will emit a resource warning because the open file is not closed explicitly. But this is a different issue.
msg327645 - (view)	Author: Serhiy Storchaka (serhiy.storchaka) *	Date: 2018-10-13 09:27
New changeset d4d60134b29290049e28df54f23493de4f1824b6 by Serhiy Storchaka (Zackery Spytz) in branch 'master': bpo-16965: 2to3 now rewrites execfile() to open with 'rb'. (GH-8569) https://github.com/python/cpython/commit/d4d60134b29290049e28df54f23493de4f1824b6
msg327646 - (view)	Author: miss-islington (miss-islington)	Date: 2018-10-13 09:48
New changeset 22381394ad1541db0b652eed802601f62510d22f by Miss Islington (bot) in branch '3.7': bpo-16965: 2to3 now rewrites execfile() to open with 'rb'. (GH-8569) https://github.com/python/cpython/commit/22381394ad1541db0b652eed802601f62510d22f
msg327647 - (view)	Author: miss-islington (miss-islington)	Date: 2018-10-13 09:51
New changeset 950fa40eee483f7507cd825b574a018b957dd253 by Miss Islington (bot) in branch '3.6': bpo-16965: 2to3 now rewrites execfile() to open with 'rb'. (GH-8569) https://github.com/python/cpython/commit/950fa40eee483f7507cd825b574a018b957dd253
msg327809 - (view)	Author: Serhiy Storchaka (serhiy.storchaka) *	Date: 2018-10-16 05:46
New changeset f5e00f490ab5abfcf5e38e58bf969c7b5dcb4818 by Serhiy Storchaka (Zackery Spytz) in branch '2.7': [2.7] bpo-16965: 2to3 now rewrites execfile() to open with rb. (GH-8569) (GH-9890) https://github.com/python/cpython/commit/f5e00f490ab5abfcf5e38e58bf969c7b5dcb4818