Issue 17077: Fix test_tools hangs (original) (raw)

Issue17077

Created on 2013-01-29 18:39 by jkloth, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
test_tools.diff jkloth,2013-01-29 18:39 review
Messages (4)
msg180925 - (view) Author: Jeremy Kloth (jkloth) * Date: 2013-01-29 18:39
Attached is a patch to test_tools that gets it back to a run-able state.
msg180965 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2013-01-30 06:37
On what platform it hangs? Note that communicate() currently works only with bytes on 3.2 ().
msg180973 - (view) Author: Jeremy Kloth (jkloth) * Date: 2013-01-30 10:21
It hangs on both my Windows buildbot and development machine. The patch is tested and works correctly on Windows.
msg181339 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2013-02-04 15:55
Committed changeset 4be538a058a8. Thank you for the patch.
History
Date User Action Args
2022-04-11 14:57:41 admin set github: 61279
2013-02-04 15:55:19 serhiy.storchaka set status: open -> closedresolution: fixedmessages: + stage: patch review -> resolved
2013-01-30 13:31:46 serhiy.storchaka set assignee: serhiy.storchakadependencies: + subprocess.Popen.communicate with universal_newlines=True doesn't accept strings on 3.2type: behaviorstage: patch review
2013-01-30 12:28:24 vstinner set nosy: + vstinner
2013-01-30 10:21:59 jkloth set messages: +
2013-01-30 06:37:07 serhiy.storchaka set messages: +
2013-01-29 18:39:37 jkloth create