Issue 17352: Be clear that prepare must be declared as a class method (original) (raw)

Created on 2013-03-04 15:11 by ncoghlan, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Messages (5)
msg183463 - (view)	Author: Alyssa Coghlan (ncoghlan) *	Date: 2013-03-04 15:11
The docs on __prepare__ don't make it clear that it should be a staticmethod, and the error message if you forget is not obvious at all. (This is particularly so, since the examples in PEP 3115 had it as an ordinary method).
msg183466 - (view)	Author: Alyssa Coghlan (ncoghlan) *	Date: 2013-03-04 15:28
Class method, not static method (super() breaks if you declare it as a static method)
msg237095 - (view)	Author: Ethan Furman (ethan.furman) *	Date: 2015-03-03 00:10
Should __prepare__ be special-cased as a classmethod, like __new__ is? Is there any reason to ever have __prepare__ /not/ be a classmethod?
msg237127 - (view)	Author: Alyssa Coghlan (ncoghlan) *	Date: 2015-03-03 12:36
__new__ is a little weird - it's actually special cased as a staticmethod. Your questions is still valid, though. For existing versions, documenting the requirement is the only option. For future versions, we could conceivably implement a "decorate it if it isn't already decorated" fallback, but for backwards compatibility we'd have to avoid double-decorating explicitly decorated implementations.
msg267032 - (view)	Author: Berker Peksag (berker.peksag) *	Date: 2016-06-03 04:21
This is a duplicate of issue 15243.